539116 - JavaScript error: chrome://browser/content/browser-ui.js, line 1119: aElement is null

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

There is a little focus bug when going from the form assistant to the urlbar which is annoying (because it prevent you to move with the arrows in the awesome list) and create an error.

Step to repro:
 * go to aircanada.com
 * click on a list
 * when you have the formfill opened, click on the urlbar and try to use the down arrow key
 * (normally you can't - that's a bug)
 * dismiss the awesome panel by clicking on the top right corner arrow
 * go back to the urlbar and type in bugzilla.org -> ENTER
 * once in bugzilla click on the first search field

Actual result:
 * an exception is throw

Expected result:
 * the formfill appears

The following patch correct both bugs.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We could almost even remove the event.type == "keypress" check. It's the only event we listen for.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 421153 [details] [diff] [review]
Patch

Ben - anything jump out at you? This is headed to RC3.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to default:
https://hg.mozilla.org/mobile-browser/rev/91ea40f29e9b

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2pre) Gecko/20100114 Firefox/3.6pre Fennec/1.1a1pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20100114 Firefox/3.7a1pre Fennec/1.1a1pre

Comment 5

[Dão Gottwald [:dao]]

bugspam