539248 - do not stick places.*.corrupt in Roaming on windows

Status: RESOLVED INACTIVE

(Toolkit :: Places, defect, P5)

Description

[timeless]

C:\Users\timeless\AppData\Roaming\Mozilla\Firefox\Profiles\whatever.default
...
12/20/2009  01:37 PM           487,424 places.sqlite-1587.corrupt
...

I discovered that I had >1,000 of these files, each is 1/2 mb, collectively, i had 1gb of them. That's a lot of data to roam. If we must maintain these files, then we really should *not* store them in the roaming portion of the profile.

Comment 1

[Marco Bonardo [:mak]]

3.6 and 3.7 won't create more than 1 .corrupt per day. that said, we never found them useful, they are there just because the user could want to use third party ways to recover its bookmarks in case our backups would fail, not a so strong user-case, we could even completely drop code doing that.

Comment 2

[Marco Bonardo [:mak]]

looking at the database it is schema v8 (early 3.5 version) so this looks like bug 493291.

We should probably still add a preventive maintenance task to remove those corrupt files if they are too many (hard to determine, with a 100MB database, 2 corrupt files will already take up 200MB).
Since 3.7 will try to create 10 json backups, instead of 5, we could also evaluate to drop creating corrupt at all, maybe spacing the json backups more in time.

Comment 3

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.