539365 - Lightweight themes text-shadow exists on print-preview screen

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Tony Chung [:tchung]]

The text-shadow work from light weight theme exists in windows, when entering print-preview mode.   Disabling lightweight themes will restore to default view.

* Does not reproduce on Mac OSX builds.

Repro:
1) launch 1.9.2 nightly or Fx3.6rc1
2) install any lightweight theme
3) pick a website, and go to File > Print Preview for that front page
4) Verify the header, buttons, has text-shadowing themes around it.

Expected:
- Lightweight theming text-shadowing should not affect print preview buttons

Actual:
- text-shadowed buttons

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Buttons and menulists shouldn't inherit text-shadow, as they don't inherit the text color and have a background. It's not clear to me why Tony didn't see this on OS X, I think it's needed there as well.

Comment 2

[Tony Chung [:tchung]]

(In reply to comment #1)
> Created an attachment (id=421419) [details]
> patch
> 
> Buttons and menulists shouldn't inherit text-shadow, as they don't inherit the
> text color and have a background. It's not clear to me why Tony didn't see this
> on OS X, I think it's needed there as well.

oh, thats cause mac is opening the Preview application when doing print-preview.  Versus windows using its own.

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e8dd94ccda9d

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 421419 [details] [diff] [review]
patch

a1922=beltzner

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/76cf6e0523fe

Comment 7

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3pre) Gecko/20100322 Namoroka/3.6.3pre