Closed
Bug 539378
Opened 15 years ago
Closed 15 years ago
Remove MOZ_BITS macro from tree
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
|
4.47 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
OS_BITS is a macro from Netscape 5 client. But we don't need 16-bit client as mozilla code and this is hardcode value in config/autoconfig.mk, so we should remove it. Also, x64 target doesn't use it.
This is from Bug 469654 comment #14. Brendan said "MOZ_BITS die die die! No mo 16 vs. 32 bit memories. Calgon, take me awayyy! ;-)"
|
Assignee | |
Updated•15 years ago
|
Summary: Remove OS_BITS macro from tree → Remove MOZ_BITS macro from tree
|
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Updated•15 years ago
|
Attachment #421392 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 421392 [details] [diff] [review]
patch v1
This is fine, but if I were you I would go one step further and get rid of all those "32"s from filenames, like I had you do with the JS DLL.
Attachment #421392 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•15 years ago
|
||
(In reply to comment #2)
> (From update of attachment 421392 [details] [diff] [review])
> This is fine, but if I were you I would go one step further and get rid of all
> those "32"s from filenames, like I had you do with the JS DLL.
OK. I consider comm-central tree too by new bug.
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•