Closed Bug 539378 Opened 10 years ago Closed 10 years ago

Remove MOZ_BITS macro from tree

Categories

(Firefox Build System :: General, defect)

x86
Windows Vista
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

OS_BITS is a macro from Netscape 5 client.  But we don't need 16-bit client as mozilla code and this is hardcode value in config/autoconfig.mk, so we should remove it.  Also, x64 target doesn't use it.

This is from Bug 469654 comment #14.  Brendan said "MOZ_BITS die die die! No mo 16 vs. 32 bit memories. Calgon, take me awayyy! ;-)"
Summary: Remove OS_BITS macro from tree → Remove MOZ_BITS macro from tree
Attached patch patch v1Splinter Review
Attachment #421392 - Flags: review?(ted.mielczarek)
Comment on attachment 421392 [details] [diff] [review]
patch v1

This is fine, but if I were you I would go one step further and get rid of all those "32"s from filenames, like I had you do with the JS DLL.
Attachment #421392 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/5db012421dfd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to comment #2)
> (From update of attachment 421392 [details] [diff] [review])
> This is fine, but if I were you I would go one step further and get rid of all
> those "32"s from filenames, like I had you do with the JS DLL.

OK. I consider comm-central tree too by new bug.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.