539495 - aPNG throbber is using a lot of CPU and is slowing pageload times

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

loading chrome://browser/skin/images/throbber.png into Fennec shows a ~50% CPU usage when the app is idle. This could affect UI responsiveness during a pageload.

Also, removing the throbber from Fennec results in ~14% speedup of pageload times.

We should look at ways to change the throbber for the better.

See bug 437829 for more

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: script to make throbber

Use this script and the aPNG Editor Firefox add-on to make the throbbers used in Fennec

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: 4fps throbber (20 frames for 5 sec)

This is the 4fps throbber we intend to use. It is made of 20 frames for 5 seconds, which gives it a choppy, but quicker pace than smoother and slower 4fps throbbers

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Patch that uses the 4fps throbber. With this patch our pageload times are not noticeably faster, but the cpu usage is now 13% - down from 55%

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 421671 [details] [diff] [review]
patch

Gimme more view like this!

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to default:
http://hg.mozilla.org/mobile-browser/rev/0f5e8f0b442c

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2pre) Gecko/20100114 Firefox/3.6pre Fennec/1.1a1pre