539512 - Font Color changes with Persona's Skins

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Jeremy]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b1 Thunderbird/3.0

When persona's is installed and a dark theme is selected, the font colors for the Today Pane are changed to be very light colors. This would be fine if the Today Pane changed to a darker color - but it does not. As a result one is unable to select a dark persona's skin like "Abstract Splash" and still easily see the date.

Reproducible: Always

Steps to Reproduce:
1. Start Thunderbird 3
2. Display the Today Pane if not displayed.
3. Use Persona's to select a dark theme like "Abstract Splash".
4. Notice that the font colors for the "Events" text and date are changed.
Actual Results:  
The font colors for the word "Events" and for the date and time changed.

Expected Results:  
If the background of the software does not change then the font colors should not change.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Setting a color in addition to the background color makes the color go back to black.

I do wonder what the policy for css rules in personas is though. I think the sidebar header could use an opacity: 0.8 in personas CSS files.

ssitter, do you have a windows machine to test this on? Martin, could you test this on mac?

Comment 2

[Stefan Sitter [:ssitter]]

Comment on attachment 430981 [details] [diff] [review]
Fix - v1

r=ssitter

No change required for pinstripe?

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

Duh, obviously. Seems I didn't qref.

Comment 4

[Martin Schröder [:mschroeder]]

Comment on attachment 431034 [details] [diff] [review]
Fix - v2

Also works on Mac! :)

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/f5df58de9aca>

-> FIXED