539629 - lirasm: don't have two ways of running the tests

Status: RESOLVED FIXED

(Core Graveyard :: Nanojit, defect)

Description

[Nicholas Nethercote [inactive]]

In nanojit-central, we have a make target for running the NJ tests.  In TM we have to use the testlirc.sh script.  This sucks.  My proposal is to change the NJ-central make target to just invoke the testlirc.sh script.  This'll require changing the script such that it outputs results in a way suitable for tinderbox, but this shouldn't be hard.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: NJ patch

This patch:
- Removes the testing done from the Makefile, just invokes testlirc.sh 
  instead.
  
- Changes testlirc.sh to take the location of the 'lirasm' executable as an
  argument, needed to handle differences in directory layout in NJ-central 
  vs TM.
  
- Changes testlirc.sh to produce output in the tinderbox format.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: TM patch

Comment 3

[Graydon Hoare :graydon]

I actually wanted to move towards using the makefile (make does better rule-chaining and parallel execution than sh) but every time I suggest this someone yells at me about the misery they feel writing in make-language (as though bourne shell is better?)

So I guess this is ok. It'll be more popular anyway :)

Comment 4

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/projects/nanojit-central/rev/c41f7c86b3cd

Comment 5

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/tracemonkey/rev/c9d6e88d3320
http://hg.mozilla.org/tracemonkey/rev/b6fafac39034

Nb: no need to change anything in TR for this bug, because it doesn't have a copy of lirasm.

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/c9d6e88d3320