Simple Alive test for the Applications Prefpane (Port browser_bug410900.js)

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Preferences
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Trunk
seamonkey2.1a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
From Bug 538164 comment 12 :

> Is there a consumer of this? This smells like something we usually add mainly
> for tests to use, if there is an actual test for the pane, we probably should
> port that as well.

> If so, as I said, we really should do that, but it can be done in a followup.
Depends on: 410900
Summary: Port browser_browser_bug410900.js → Port browser_bug410900.js
(Assignee)

Updated

7 years ago
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
No longer depends on: 410900
Summary: Port browser_bug410900.js → Simple Alive test for the Applications Prefpane (Port browser_bug410900.js)
(Assignee)

Comment 1

7 years ago
Created attachment 430856 [details] [diff] [review]
Patch v1.0 initial implementation. [Checkin: comment 3]

Notes:

The Firefox test was using:
+    if (items[i].type == "apppanetest") 
For some reason in SeaMonkey .type was returning undefined, probably because of (listitem vs richlistitem) so I used the attribute instead.

I found two ways of running this test:

1. pure command line:
cd $COMM_CENTRAL$
TEST_PATH=suite/common/tests/preferences/ make -C ../objdir-sm/ mochitest-browser-chrome

2. call up the mochitest UI to run interactively.

cd $OBJ_DIR$
python mozilla/_tests/testing/mochitest/runtests.py --browser-chrome --test-path=suite/common/tests/preferences

Passed: 4
Failed: 0
Todo: 0


Running chrome://mochikit/content/browser/suite/common/tests/preferences/browser_bug410900.js...
....snip....
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/preferences/browser_bug410900.js | Specified pane was opened
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/preferences/browser_bug410900.js | handlersView is present
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/preferences/browser_bug410900.js | App handler list populated
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/preferences/browser_bug410900.js | apppanetest protocol handler was succesfully added
TEST-INFO | chrome://mochikit/content/browser/suite/common/tests/preferences/browser_bug410900.js | Console message: [JavaScript Error: "uncaught exception: [Exception... "Not enough arguments"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: chrome://global/content/bindings/textbox.xml ::  :: line 160"  data: no]"]

Ignore the last bit which appears to be fallout from the emptytext-to-placeholder patch. Obvious typo should be getAttribute() instead of setAttribute().
Attachment #430856 - Flags: review?(neil)
Attachment #430856 - Flags: feedback?(bugspam.Callek)

Comment 2

7 years ago
Comment on attachment 430856 [details] [diff] [review]
Patch v1.0 initial implementation. [Checkin: comment 3]

Seems reasonable enough.
Attachment #430856 - Flags: review?(neil) → review+

Updated

7 years ago
Attachment #430856 - Flags: feedback?(bugspam.Callek) → feedback+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Comment on attachment 430856 [details] [diff] [review]
Patch v1.0 initial implementation. [Checkin: comment 3]

http://hg.mozilla.org/comm-central/rev/f663c3879c22
Attachment #430856 - Attachment description: Patch v1.0 initial implementation. → Patch v1.0 initial implementation. [Checkin: comment 3]
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
You need to log in before you can comment on or make changes to this bug.