539722 - Port |Bug 515433 - (CSP) Implement core CSP elements| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Package contentSecurityPolicy.js [Checkin: Comment 10]

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-191) Support downgrading [Checkin: Comment 11]

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 421649 [details] [diff] [review]
(Bv1-191) Support downgrading
[Checkin: Comment 11]

I'm not sure this downgrade path is really worth the trouble, but while your here; why not.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 421648 [details] [diff] [review]
(Av1) Package contentSecurityPolicy.js
[Checkin: Comment 10]

>+#ifdef MOZILLA_1_9_2_BRANCH
>+components/contentSecurityPolicy.js
>+#endif
> components/crashreporter.xpt
> #ifdef MOZILLA_1_9_2_BRANCH
> components/crypto-SDR.js
> #endif

...

> #ifndef MOZILLA_1_9_2_BRANCH
>+bin\components\contentSecurityPolicy.js
> bin\components\crypto-SDR.js
> #endif

Nit: keep groupings consistent, preferably one if[n]def.

Not ready to land until Bug 515433 does. IFF there is an new iteration there, I want to re-review this (or a new patch) before you push though. [Current at time of this review is v7.5]

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> Nit: keep groupings consistent, preferably one if[n]def.

I'm rather keeping the list sorted: the if[n]def will be removed after branching...

Comment 6

[Justin Wood (:Callek)]

(In reply to comment #5)
> (In reply to comment #4)
> > Nit: keep groupings consistent, preferably one if[n]def.
> 
> I'm rather keeping the list sorted: the if[n]def will be removed after
> branching...

You convinced me, nit retracted.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 421648 [details] [diff] [review]
(Av1) Package contentSecurityPolicy.js
[Checkin: Comment 10]


Per your comment 4: there was a v7.6 version of the Core patch...

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 421648 [details] [diff] [review]
(Av1) Package contentSecurityPolicy.js
[Checkin: Comment 10]

no change to this patch needed, thanks.

Comment 9

[Philip Chee]

> [Not ready to land until Bug 515433 does]
The relevant build config change seems to have landed.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 421648 [details] [diff] [review]
(Av1) Package contentSecurityPolicy.js
[Checkin: Comment 10]


http://hg.mozilla.org/comm-central/rev/8b266f10c466

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 421649 [details] [diff] [review]
(Bv1-191) Support downgrading
[Checkin: Comment 11]


http://hg.mozilla.org/releases/comm-1.9.1/rev/ca986f28d2c1