Closed Bug 539863 Opened 15 years ago Closed 14 years ago

Stop setting Mac value for SeaMonkey-only browser.urlbar.clickAtEndSelects pref in all.js

Categories

(Core :: Preferences: Backend, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a3

People

(Reporter: philor, Assigned: philor)

References

()

Details

Attachments

(1 file)

Attached patch rmSplinter Review
Came up in a Camino bug about how the pref didn't do what it sounds like it would do, which is the case because it's only SeaMonkey that cares about reading browser.urlbar.clickAtEndSelects, which they set to true on every platform in suite/browser/browser-prefs.js, overriding the Mac false from all.js, so the only effect of having it in all.js in a Mac ifdef is to make it show up in about:config in Mac Firefox and Camino where it does nothing, and Mac Thunderbird (and anyone else who uses all.js) where it doesn't even have a hypothetical but unimplemented point.

I'd stop blaming you for things you copied in back in bug 224578, but I don't really know of a better alternative owner for all.js.
Attachment #421760 - Flags: review?(benjamin)
Hardware: x86 → All
Attachment #421760 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/mozilla-central/rev/c6a70810c37e
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: