53990 - XIM: preedit problems at over-the-spot style

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Masaki Katakai]

When over-the-spot style, there are some problems,

 - preedit isn't rendered at correct position at first startup

   At startup, IMESetFocusWidget() is called with x=0,y=0,h=1,w=1.
   We need to update preedit area - height and width of focused
   window when the window is resized.

 - SetXICBaseFontSize() and SetXICSpotLocation() are called
   but not needed

   These functions should be called only when the cursor position is
   updated. However, these are called every time by timer because
   oldy is stored after + compEvent.theReply.mCursorPosition.height,

       spot.y = compEvent.theReply.mCursorPosition.y +
                compEvent.theReply.mCursorPosition.height;

       oldy = spot.y;

  but it will be compared with compEvent.theReply.mCursorPosition.y
  at next time. So the following always true by mistake.

 - It depends on Linux distribution and user's setting of fontpath,
   however, italic fonts are used for preedit and status drawing.

    gPreeditFontset = gdk_fontset_load("-*-*-*-*-*-*-16-*-*-*-*-*-*-*");

   It should be,

    gPreeditFontset = gdk_fontset_load("-*-*-*-r-*-*-16-*-*-*-*-*-*-*");

   to get regular font.

I made a patch already. I'll ask [e-mail] to
review the patch, then post the patch.

Comment 1

[Hidetoshi Tajima]

I attached the patch proposed by Masaki to bug 53989. r=[e-mail].

Comment 2

[Hidetoshi Tajima]

r=[e-mail] has been wanted.

Comment 3

[Hidetoshi Tajima]

r=[e-mail] has been wanted.

Comment 4

[Erik van der Poel]

Please see my comments in bug 53989, and please attach a new patch to this bug
report.

Comment 5

[Masaki Katakai]

OK, I'll attach the new patch.

Comment 6

[Masaki Katakai]

Attachment: changes for this problem, updated as erik's comments

Comment 7

[Erik van der Poel]

Masaki, are you sure that you attached the right patch? It does not seem to
have the font-related changes in it.

Comment 8

[Masaki Katakai]

Attachment: sorry, here is correct patch

Comment 9

[Erik van der Poel]

The 2nd patch does not address the comments that I made in bug 53989. Also, it
contains the patch for bug 53989. It should not contain that patch. Please keep
the patches for these bugs separate.

See the following comments in bug 53989:

  2000-10-25 11:49
  2000-10-27 17:19

Comment 10

[Masaki Katakai]

Attachment: sorry again, I attached wrong file. Here is correct one.

Comment 11

[Erik van der Poel]

r=erik

Comment 12

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 13

[Masaki Katakai]

patch checked in by Toshi.

Comment 14

[Masaki Katakai]

checked in.

Comment 15

[Koike Kazuhiko]

One problem related to this bug still remains.

If you enter "<<aiueo>>abcdef<<kakikukeko>>" in Japanese code,
<<kakikukeko>> is displayed with bold font.

Should I file a new bug?

Comment 16

[Christopher Blizzard (:blizzard)]

Yes, file a new bug.

Comment 17

[Koike Kazuhiko]

I filed bug 78704.

Comment 18

[Masaki Katakai]

Marked as VERIFIED, as Koike-san's comments.