540074 - crash [@ nsMsgDatabase::DeleteHeader(nsIMsgDBHdr*, nsIDBChangeListener*, int, int)] with pop account

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Wayne Mery (:wsmwk)]

crash [@ nsMsgDatabase::DeleteHeader(nsIMsgDBHdr*, nsIDBChangeListener*, int, int)]

~#100 for v3.0.0. all 3 OS. All pop
rare on trunk - only 1 in 6 months

bp-46e02138-2c72-499c-905c-201e92100112
(pop) tried to download the mail after fetching the header and TB3 crashed
0	thunderbird.exe	nsMsgDatabase::DeleteHeader	 mailnews/db/msgdb/src/nsMsgDatabase.cpp:1758
1	thunderbird.exe	nsPop3Sink::CheckPartialMessages	mailnews/local/src/nsPop3Sink.cpp:256
2	thunderbird.exe	nsPop3Sink::AbortMailDelivery	mailnews/local/src/nsPop3Sink.cpp:524
3	thunderbird.exe	nsPop3Protocol::Abort	mailnews/local/src/nsPop3Protocol.cpp:812
4	thunderbird.exe	nsPop3Protocol::Cancel	mailnews/local/src/nsPop3Protocol.cpp:819
5	thunderbird.exe	nsLoadGroup::Cancel	netwerk/base/src/nsLoadGroup.cpp:344
6	thunderbird.exe	nsDocLoader::Stop	uriloader/base/nsDocLoader.cpp:313
7	thunderbird.exe	nsDocShell::Stop	docshell/base/nsDocShell.cpp:3619
8	thunderbird.exe	nsDocShell::InternalLoad	docshell/base/nsDocShell.cpp:7413
9	thunderbird.exe	nsDocShell::LoadURI	docshell/base/nsDocShell.cpp:963
10	thunderbird.exe	nsLocation::SetURI	dom/src/base/nsLocation.cpp:377

Comment 1

[timeless]

Attachment: xpcom means you must accept null pointers (esp undefined from js)

Comment 2

[David :Bienvenu]

Comment on attachment 422012 [details] [diff] [review]
xpcom means you must accept null pointers (esp undefined from js)

I don't have a reproducible case for this, so I can't imagine a test case.

Comment 3

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/ebf6557ad89e

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 422012 [details] [diff] [review]
xpcom means you must accept null pointers (esp undefined from js)

bienvenu, safe enough for propose landing for 3.1?

Comment 5

[David :Bienvenu]

Comment on attachment 422012 [details] [diff] [review]
xpcom means you must accept null pointers (esp undefined from js)

yes, should be ok for 3.1 - basically a "don't crash" fix.

Comment 6

[Mark Banner (:standard8)]

Checked into 1.9.2:
http://hg.mozilla.org/releases/comm-1.9.2/rev/011dd0b3d7a1