Closed Bug 540084 Opened 10 years ago Closed 10 years ago

meta viewport tag remembers last visit

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Maemo
defect
Not set

Tracking

(fennec1.0+)

VERIFIED FIXED
fennec1.0
Tracking Status
fennec 1.0+ ---

People

(Reporter: claes.norin, Assigned: mfinkle)

References

()

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-GB; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7
Build Identifier: Mozilla/5.0 (X11; U; Linux armv7l;en-US;rv: 1.9.2) Gecko/20100107/Firefox/3.6 Fennec/1.0.0

The meta viewport settings is not reset on a new website. If the previous website had a meta viewport setting this setting will be on the next website you visit (if the new website does not have this setting on its own).

Reproducible: Always

Steps to Reproduce:
1. Go to facebook.com, notice background renders only 800px wide and chops unde the form. 
2. Go to maemosweden.com or some other webpage with a meta viewport tag set to something else than 800px 
3. After visit from step 2 go to facebook.com again and notice the viewport is set as maemosweden.com (in this case)
Actual Results:  
It remebers last viewport settting

Expected Results:  
It should be resetted to default (800px) which my personal suggestion would be 1024px. Another topic however..
Attached patch patch (obsolete) — Splinter Review
We need to reset the browser.style.width that is set when a page has a viewport meta tag.
Assignee: nobody → mark.finkle
Attachment #422239 - Flags: review?(bugmail)
Attachment #422239 - Flags: review?(21)
Simple easy low risk fix
tracking-fennec: --- → ?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #422239 - Flags: review?(bugmail) → review+
Attached patch patch 2Splinter Review
Same as previous patch but I use style.removeProperty("width") instead of style.width = ""

It does the same thing, but is more explicit
Attachment #422239 - Attachment is obsolete: true
Attachment #422320 - Flags: superreview?(pavlov)
Attachment #422320 - Flags: review?(21)
Attachment #422320 - Flags: superreview?(pavlov) → superreview+
tracking-fennec: ? → 1.0+
pushed to default:
http://hg.mozilla.org/mobile-browser/rev/7551cb2082ee
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
veirfied FIXED that Facebook doesn't look odd, but there's two things here:

1. Facebook is showing the mobile version of its website 
2. The top and bottom bars, once logged in, are now only 2/5's the width of the page where it was 4/5 - 9/10's.
Target Milestone: --- → RC
follow-up bug filed for facebook issue. https://bugzilla.mozilla.org/show_bug.cgi?id=540667
Status: RESOLVED → VERIFIED
Component: Linux/Maemo → General
OS: Linux → Linux (embedded)
QA Contact: maemo-linux → general
Hardware: Other → ARM
You need to log in before you can comment on or make changes to this bug.