Last Comment Bug 540209 - Kill MsgReload
: Kill MsgReload
Status: RESOLVED FIXED
[extension love]
:
Product: SeaMonkey
Classification: Client Software
Component: MailNews: General (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: seamonkey2.1a1
Assigned To: Edmund Wong (:ewong)
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-16 14:19 PST by Karsten Düsterloh
Modified: 2010-03-18 15:00 PDT (History)
3 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Replacing all MsgReload() with ReloadMessage() (6.21 KB, patch)
2010-03-01 00:15 PST, Edmund Wong (:ewong)
no flags Details | Diff | Review
Previous patch invalid. Added one too many 's' to ReloadMessage() [Checkin: comment 6] (6.20 KB, patch)
2010-03-01 00:20 PST, Edmund Wong (:ewong)
mnyromyr: review+
mnyromyr: superreview+
Details | Diff | Review

Description Karsten Düsterloh 2010-01-16 14:19:57 PST
mailWindowOverlay.js:

2016 function MsgReload()
2017 {
2018     ReloadMessage();
2019 }

TB3 doesn't have this function anymore either, it's just using ReloadMessage directly everywhere. 
This means, as an extension author writing for both SM and TB, you'd probably end up (unnecessarily) special-casing every call to that function, because you can't be sure that we don't do extra stuff in MsgReload...

Let's just remove MsgReload() and call ReloadMessage() instead.
Comment 1 Edmund Wong (:ewong) 2010-03-01 00:15:29 PST
Created attachment 429479 [details] [diff] [review]
Replacing all MsgReload() with ReloadMessage()
Comment 2 Edmund Wong (:ewong) 2010-03-01 00:20:31 PST
Created attachment 429480 [details] [diff] [review]
Previous patch invalid.   Added one too many 's' to ReloadMessage() [Checkin: comment 6]
Comment 3 Edmund Wong (:ewong) 2010-03-01 00:36:21 PST
(In reply to comment #2)
> Created an attachment (id=429480) [details]
> Previous patch invalid.   Added one too many 's' to ReloadMessage()

As well as removing function MsgReload() from 
suite/mailnews/mailWindowOverlay.js.
Comment 4 Karsten Düsterloh 2010-03-14 13:52:58 PDT
Comment on attachment 429480 [details] [diff] [review]
Previous patch invalid.   Added one too many 's' to ReloadMessage() [Checkin: comment 6]

Sorry for the delay. :(
Comment 5 Karsten Düsterloh 2010-03-18 00:11:13 PDT
Comment on attachment 429480 [details] [diff] [review]
Previous patch invalid.   Added one too many 's' to ReloadMessage() [Checkin: comment 6]

>            Keywords|                            |checkin-needed

In SM mail, you need sr or moa, see <http://www.seamonkey-project.org/dev/review-and-flags>.
That said, moa=me.
Comment 6 Jens Hatlak (:InvisibleSmiley) 2010-03-18 13:55:49 PDT
Comment on attachment 429480 [details] [diff] [review]
Previous patch invalid.   Added one too many 's' to ReloadMessage() [Checkin: comment 6]

http://hg.mozilla.org/comm-central/rev/1e618f0d591d

Note You need to log in before you can comment on or make changes to this bug.