540209 - Kill MsgReload

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Karsten Düsterloh]

mailWindowOverlay.js:

2016 function MsgReload()
2017 {
2018     ReloadMessage();
2019 }

TB3 doesn't have this function anymore either, it's just using ReloadMessage directly everywhere. 
This means, as an extension author writing for both SM and TB, you'd probably end up (unnecessarily) special-casing every call to that function, because you can't be sure that we don't do extra stuff in MsgReload...

Let's just remove MsgReload() and call ReloadMessage() instead.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Replacing all MsgReload() with ReloadMessage()

Comment 2

[Edmund Wong (:ewong)]

Attachment: Previous patch invalid. Added one too many 's' to ReloadMessage() [Checkin: comment 6]

Comment 3

[Edmund Wong (:ewong)]

(In reply to comment #2)
> Created an attachment (id=429480) [details]
> Previous patch invalid.   Added one too many 's' to ReloadMessage()

As well as removing function MsgReload() from 
suite/mailnews/mailWindowOverlay.js.

Comment 4

[Karsten Düsterloh]

Comment on attachment 429480 [details] [diff] [review]
Previous patch invalid.   Added one too many 's' to ReloadMessage() [Checkin: comment 6]

Sorry for the delay. :(

Comment 5

[Karsten Düsterloh]

Comment on attachment 429480 [details] [diff] [review]
Previous patch invalid.   Added one too many 's' to ReloadMessage() [Checkin: comment 6]

>            Keywords|                            |checkin-needed

In SM mail, you need sr or moa, see <http://www.seamonkey-project.org/dev/review-and-flags>.
That said, moa=me.

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 429480 [details] [diff] [review]
Previous patch invalid.   Added one too many 's' to ReloadMessage() [Checkin: comment 6]

http://hg.mozilla.org/comm-central/rev/1e618f0d591d