Status

SeaMonkey
MailNews: General
--
trivial
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Karsten Düsterloh, Assigned: ewong)

Tracking

Trunk
seamonkey2.1a1
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [extension love], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
mailWindowOverlay.js:

2016 function MsgReload()
2017 {
2018     ReloadMessage();
2019 }

TB3 doesn't have this function anymore either, it's just using ReloadMessage directly everywhere. 
This means, as an extension author writing for both SM and TB, you'd probably end up (unnecessarily) special-casing every call to that function, because you can't be sure that we don't do extra stuff in MsgReload...

Let's just remove MsgReload() and call ReloadMessage() instead.
Severity: normal → trivial
Flags: in-testsuite-
Version: unspecified → Trunk
(Assignee)

Updated

7 years ago
Assignee: nobody → edmund
Status: NEW → ASSIGNED
(Assignee)

Comment 1

7 years ago
Created attachment 429479 [details] [diff] [review]
Replacing all MsgReload() with ReloadMessage()
Attachment #429479 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #429479 - Flags: review? → review?(mnyromyr)
(Assignee)

Comment 2

7 years ago
Created attachment 429480 [details] [diff] [review]
Previous patch invalid.   Added one too many 's' to ReloadMessage() [Checkin: comment 6]
Attachment #429479 - Attachment is obsolete: true
Attachment #429480 - Flags: review?(mnyromyr)
Attachment #429479 - Flags: review?(mnyromyr)
(Assignee)

Comment 3

7 years ago
(In reply to comment #2)
> Created an attachment (id=429480) [details]
> Previous patch invalid.   Added one too many 's' to ReloadMessage()

As well as removing function MsgReload() from 
suite/mailnews/mailWindowOverlay.js.
(Reporter)

Comment 4

7 years ago
Comment on attachment 429480 [details] [diff] [review]
Previous patch invalid.   Added one too many 's' to ReloadMessage() [Checkin: comment 6]

Sorry for the delay. :(
Attachment #429480 - Flags: review?(mnyromyr) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Reporter)

Updated

7 years ago
Attachment #429480 - Flags: superreview+
(Reporter)

Comment 5

7 years ago
Comment on attachment 429480 [details] [diff] [review]
Previous patch invalid.   Added one too many 's' to ReloadMessage() [Checkin: comment 6]

>            Keywords|                            |checkin-needed

In SM mail, you need sr or moa, see <http://www.seamonkey-project.org/dev/review-and-flags>.
That said, moa=me.
Comment on attachment 429480 [details] [diff] [review]
Previous patch invalid.   Added one too many 's' to ReloadMessage() [Checkin: comment 6]

http://hg.mozilla.org/comm-central/rev/1e618f0d591d
Attachment #429480 - Attachment description: Previous patch invalid. Added one too many 's' to ReloadMessage() → Previous patch invalid. Added one too many 's' to ReloadMessage() [Checkin: comment 6]
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
Whiteboard: [good first bug][extension love] → [extension love]
You need to log in before you can comment on or make changes to this bug.