540235 - nsDocShell.cpp can access nsContentUtils.cpp

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

In bug 500328, I discovered that I can add an nsAutoScriptBlocker to code in nsDocShell.cpp without breaking the build.  Boris, Jonas, and I are all surprised by this [1].

The attached patch builds without error on my Linux box.  I'll push to try and make sure that it compiles elsewhere, but I suspect that it will, since my patch for bug 500328 builds on all the try platforms.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=500328#c72

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Suspiciously build error-free patch

Comment 2

[Justin Lebar (not reading bugmail)]

Hm...this is compiling fine on try, but dying when it's run [1].  I think I may have just put the script blocker in a bad place, though.

[1] http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1263695672.1263699748.32509.gz

Comment 3

[Justin Lebar (not reading bugmail)]

Attachment: Suspiciously build error-free patch which doesn't crash FF

As suspected, the previous patch crashed on load because I was creating the script blocker before nsContentUtils::Init() was called.  I put the script blocker into the print preview function, and calling print preview doesn't crash the browser.

Comment 4

[Benjamin Smedberg]

Is this an --enable-libxul build (which is the default)? I'd only expect this to break the build with --disable-libxul.

Comment 5

[Justin Lebar (not reading bugmail)]

Aha, yes.  If I build with --disable-libxul --disable-ipc, I get a compile error.  Thanks for clearing this up.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Could you just start linking dochshell to gklayout?

Comment 7

[Justin Lebar (not reading bugmail)]

Being able to access nsAutoScriptBlocker from the docshell would definitely be a lot nicer than working around that limitation.  But if we can't change the build, perhaps I'll try to move the script blocker code out of contentutils and into a more widely-included library.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think linking docshell into gklayout would be ok.

bz, benjamin, opinions?

Comment 9

[Benjamin Smedberg]

Yeah, although I think we should really just require --enable-libxul (or the equivalent static build).