Created attachment 422065 [details] [diff] [review] patch This should clearly be the other way round -- we need to warn if the first end index is equal to this start index, i.e. if endFirstRange == startRange, i.e. if endFirstRange != startRange is false. This is a fix to a debug-only assertion, so I don't think it can be tested (apart from running the above-mentioned test in debug mode).
Comment on attachment 422065 [details] [diff] [review] patch Yep some things you just can't test (and I'd argue this isn't worth testing anyway).
http://hg.mozilla.org/comm-central/rev/388ec73d6f39 I also fixed the indentation of the line below it.
Comment on attachment 422065 [details] [diff] [review] patch trivial npotdb fix.
Verified fixed for 1.9.1 by code inspection (and doesn't affect release builds).