WARNING: goofy tree selection state: two ranges are adjacent!: 'endFirstRange == startRange' with test_delete_multiple_messages_with_first_selected_message_open in test-deletion-with-multiple-displays.js

RESOLVED FIXED in Thunderbird 3.1b1

Status

MailNews Core
Backend
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

({fixed-seamonkey2.0.4})

Trunk
Thunderbird 3.1b1
fixed-seamonkey2.0.4

Thunderbird Tracking Flags

(thunderbird3.0 .2-fixed)

Details

Attachments

(1 attachment)

Created attachment 422065 [details] [diff] [review]
patch

This should clearly be the other way round -- we need to warn if the first end index is equal to this start index, i.e. if endFirstRange == startRange, i.e. if endFirstRange != startRange is false.

This is a fix to a debug-only assertion, so I don't think it can be tested (apart from running the above-mentioned test in debug mode).
Attachment #422065 - Flags: superreview?(bugzilla)
Attachment #422065 - Flags: review?(bugzilla)
Comment on attachment 422065 [details] [diff] [review]
patch

Yep some things you just can't test (and I'd argue this isn't worth testing anyway).
Attachment #422065 - Flags: superreview?(bugzilla)
Attachment #422065 - Flags: superreview+
Attachment #422065 - Flags: review?(bugzilla)
Attachment #422065 - Flags: review+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/comm-central/rev/388ec73d6f39

I also fixed the indentation of the line below it.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b1
(Assignee)

Comment 3

8 years ago
Comment on attachment 422065 [details] [diff] [review]
patch

trivial npotdb fix.
Attachment #422065 - Flags: approval-thunderbird3.0.2?
Attachment #422065 - Flags: approval-thunderbird3.0.2? → approval-thunderbird3.0.2+
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/releases/comm-1.9.1/rev/0d566dffd3f6
status-thunderbird3.0: --- → .2-fixed
Verified fixed for 1.9.1 by code inspection (and doesn't affect release builds).
Keywords: verified-thunderbird3.0

Updated

8 years ago
Keywords: fixed-seamonkey2.0.4
You need to log in before you can comment on or make changes to this bug.