540252 - WARNING: goofy tree selection state: two ranges are adjacent!: 'endFirstRange == startRange' with test_delete_multiple_messages_with_first_selected_message_open in test-deletion-with-multiple-displays.js

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch

This should clearly be the other way round -- we need to warn if the first end index is equal to this start index, i.e. if endFirstRange == startRange, i.e. if endFirstRange != startRange is false.

This is a fix to a debug-only assertion, so I don't think it can be tested (apart from running the above-mentioned test in debug mode).

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 422065 [details] [diff] [review]
patch

Yep some things you just can't test (and I'd argue this isn't worth testing anyway).

Comment 2

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/388ec73d6f39

I also fixed the indentation of the line below it.

Comment 3

[Rain [:rain1] (inactive)]

Comment on attachment 422065 [details] [diff] [review]
patch

trivial npotdb fix.

Comment 4

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/releases/comm-1.9.1/rev/0d566dffd3f6

Comment 5

[Mark Banner (:standard8)]

Verified fixed for 1.9.1 by code inspection (and doesn't affect release builds).