540265 - move nsAccUtils::FireEvent into special class

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

that's part of bug 515141. I suggest to not choose nsEventUtils name for event class because 'util' means helper, the thing that is nice but not necessary. As the part of bug 515141 (event code reorganization) we'd need a class that would be primary class, a service to fire events.

Here I want to move pure util method nsAccUtils::FireAccessibleEvent to this class to make it primary method for event firing later so that direct nsIAccessible::FireAccessibleEvent call would be wrong.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 422081 [details] [diff] [review]
patch

I guess I'm okay with a class to immediately fire events.

About the name... what do you think about "EventGun"?

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 422081 [details] [diff] [review]
patch

r=me. As per our discussion, I'm okay with this change in essence. I lean toward EventGun, but am okay with EventShell. (We can rename later)

Comment 4

[alexander :surkov (:asurkov)]

landed on 1.9.3 with EventShell - http://hg.mozilla.org/mozilla-central/rev/3ecee593edfd