Closed Bug 540265 Opened 10 years ago Closed 10 years ago

move nsAccUtils::FireEvent into special class

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

that's part of bug 515141. I suggest to not choose nsEventUtils name for event class because 'util' means helper, the thing that is nice but not necessary. As the part of bug 515141 (event code reorganization) we'd need a class that would be primary class, a service to fire events.

Here I want to move pure util method nsAccUtils::FireAccessibleEvent to this class to make it primary method for event firing later so that direct nsIAccessible::FireAccessibleEvent call would be wrong.
Attached patch patchSplinter Review
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #422081 - Flags: review?(bolterbugz)
Comment on attachment 422081 [details] [diff] [review]
patch

I guess I'm okay with a class to immediately fire events.

About the name... what do you think about "EventGun"?
Comment on attachment 422081 [details] [diff] [review]
patch

r=me. As per our discussion, I'm okay with this change in essence. I lean toward EventGun, but am okay with EventShell. (We can rename later)
Attachment #422081 - Flags: review?(bolterbugz) → review+
landed on 1.9.3 with EventShell - http://hg.mozilla.org/mozilla-central/rev/3ecee593edfd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.