540285 - stop explicit usage of nsAccEvent::prepareEvent

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[alexander :surkov (:asurkov)]

try server build will be available here - https://build.mozilla.org/tryserver-builds/[e-mail]-try-0a3c871f912b/ (includes 1-6 patches pointed in bug 515141).

Comment 3

[Marco Zehe (:MarcoZ)]

Comment on attachment 422159 [details] [diff] [review]
patch

r=me for the test part.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 422159 [details] [diff] [review]
patch

r=me, overall this is an improvement thanks; please rev CID's as needed, including:

>diff --git a/accessible/src/base/nsDocAccessible.h b/accessible/src/base/nsDocAccessible.h
>--- a/accessible/src/base/nsDocAccessible.h
>+++ b/accessible/src/base/nsDocAccessible.h

please rev NS_DOCACCESSIBLE_IMPL_CID

>--- a/accessible/src/base/nsRootAccessible.h
>+++ b/accessible/src/base/nsRootAccessible.h
>@@ -103,17 +103,18 @@ public:
>       * @param aFocusEvent       DOM focus event that caused the node/accessible to receive focus
>       * @param aForceEvent       Fire a focus event even if the last focused item was the same
>       * @return                  Boolean -- was a focus event actually fired
>       */
>     PRBool FireAccessibleFocusEvent(nsIAccessible *aFocusAccessible,
>                                     nsIDOMNode *aFocusNode,
>                                     nsIDOMEvent *aFocusEvent,
>                                     PRBool aForceEvent = PR_FALSE,
>-                                    PRBool aIsAsynch = PR_FALSE);
>+                                    PRBool aIsAsynch = PR_FALSE,
>+                                    EIsFromUserInput aIsFromUserInput = eAutoDetect);

rev NS_ROOTACCESSIBLE_IMPL_CID

The event test org looks ok.

Comment 5

[alexander :surkov (:asurkov)]

Attachment: patch2

David comments are addressed

Comment 6

[Ginn Chen]

// eAutoDetect: the value should be obtained from event state mangager

manager

      //    subtree or the same node, only the umbrelle event on the ancestor

umbrella


+// Constants used to point whether the event is from user input.
+enum EIsFromUserInput
+{
+  // eAutoDetect: the value should be obtained from event state mangager
+  eAutoDetect = -1,
+  // eNoUserInput: event is not from user input
+  eNoUserInput = 0,
+  // eFromUserInput: event is from user input
+  eFromUserInput = 1
+};

I don't like -1, 0, 1. It may cause trouble if we put it into bitfield.
Can we use 2, 0, 1?

+  if (aIsFromUserInput != eAutoDetect) {
+    mIsFromUserInput = static_cast<PRBool>(aIsFromUserInput);
+    return;
+  }
Please add a not in enum EIsFromUserInput declaration, in case we forget and change the value of  eNoUserInput and eFromUserInput in the future.
Or we can just use switch-case here.

Comment 7

[alexander :surkov (:asurkov)]

Ginn's comments are addressed. Landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/7fd680a94f25