Closed
Bug 540322
Opened 14 years ago
Closed 13 years ago
Improve the external string API to align it with the internal string API
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file, 1 obsolete file)
6.99 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
The external string API lacks many methods provided on the internal string API. This makes it hard to write code that compiles against both APIs. In particular it would be useful if the following methods were stubbed: Last SetCharAt AssignASCII [the internal API AssignLiteral only works on a real literal] AppendASCII [ditto] LowerCaseEqualsLiteral (missing from nsACString only)
Assignee | ||
Comment 1•14 years ago
|
||
Assignee | ||
Comment 2•14 years ago
|
||
Bah, I forgot that internal SetCharAt has the char first.
Attachment #422119 -
Attachment is obsolete: true
Attachment #422189 -
Flags: review?(benjamin)
Attachment #422119 -
Flags: review?(benjamin)
Updated•14 years ago
|
Attachment #422189 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Pushed changeset e3ce9abae2d5 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 4•13 years ago
|
||
It's possible that this changed caused bug 682259. Can someone please have a look and confirm?
You need to log in
before you can comment on or make changes to this bug.
Description
•