Closed
Bug 540421
Opened 16 years ago
Closed 16 years ago
Remove ANSI fallback code in nsMessengerWinIntegration.cpp
Categories
(MailNews Core :: Backend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.1b1
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
9.04 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Including:
* The fallback code for Windows 98 that exports a non-working Shell_NotifyIconW
* The ANSI biff icon data
I also optimised a call to GetModuleFileName to use the Unicode version.
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #422207 -
Flags: superreview?(bienvenu)
Attachment #422207 -
Flags: review?(bienvenu)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 422207 [details] [diff] [review]
Proposed patch
I have no idea how we could test this with mozmill...
Attachment #422207 -
Flags: superreview?(bienvenu)
Attachment #422207 -
Flags: superreview+
Attachment #422207 -
Flags: review?(bienvenu)
Attachment #422207 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Pushed changeset 7c79d282d28d to comm-central.
I don't see how you can test the removable of unusable code either.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Target Milestone: --- → Thunderbird 3.1b1
You need to log in
before you can comment on or make changes to this bug.
Description
•