54048 - mailnews/mime/src/nsStreamConverter.cpp mucking with mime internals

Status: NEW

(MailNews Core :: MIME, defect)

Description

[rhp (gone)]

The following code:

        char *urlString;
        if (NS_SUCCEEDED(aURI->GetSpec(&urlString)))
        {
          if ((urlString) && (*urlString))
          {
            CRTFREEIF(*url_name);
            *url_name = nsCRT::strdup(urlString);
            if (!(*url_name))
              return NS_ERROR_OUT_OF_MEMORY;

            // rhp: Ugh, this is ugly...but it works.
            *fixup_pointer = (const char *)*url_name;
            CRTFREEIF(urlString);
          }
        }

Is mucking with libmime internals. This should really be calling into libmime 
to make this type of memory change.

- rhp

Comment 1

[(not reading, please use [e-mail] instead)]

rhp:  thanks for not forgetting to log this bug.

Comment 2

[scottputterman]

reassigning to ducarroz

Comment 3

[scottputterman]

moving to 1.0

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Is this still valid, Jean-Francois?

Comment 5

[Wayne Mery (:wsmwk)]

This may be outside your wheelhouse - is this possibly still valid?

Comment 6

[Ben Campbell]

It's still in there:
https://searchfox.org/comm-central/search?q=rhp%3A+Ugh&case=true&regexp=false&path=mailnews%2Fmime%2Fsrc

I'd guess that it's not going to cause problems unless the libmime internals change.
I'm not familiar with any of the mime stuff, but if I ever find myself in there I'll make sure to have a go at it - it seems the least we can do after rhp was good enough to log it!

Comment 7

[Wayne Mery (:wsmwk)]

Thanks. So no real impact yet -> minor