Closed Bug 540501 Opened 15 years ago Closed 14 years ago

Inappropriate signature for nsIMsgDatabase::DeleteMessages

Categories

(MailNews Core :: Database, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

The current signature is
> [noscript] void DeleteMessages(in nsMsgKeyArrayPtr nsMsgKeys, in nsIDBChangeListener instigator);
An appropriate signature would be
> void DeleteMessages(in unsigned long aNumKeys, [array, size_is(aNumKeys)] in nsMsgKey nsMsgKeys, in nsIDBChangeListener instigator);
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #422309 - Flags: superreview?(bienvenu)
Attachment #422309 - Flags: review?(bienvenu)
Attachment #422309 - Flags: superreview?(bienvenu)
Attachment #422309 - Flags: superreview+
Attachment #422309 - Flags: review?(bienvenu)
Attachment #422309 - Flags: review+
Comment on attachment 422309 [details] [diff] [review]
Proposed patch

could change the idl to deleteMessages, since there are no js callers
Pushed changeset 2d9c6d4b8c05 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: