I'm disabling a set of JS "unit tests" that were attempting to ensure the JIT was faster than the interpreter. These tests were slow and failing intermittently. Unit tests should never depend on timing: http://joblivious.wordpress.com/2009/02/20/handling-intermittence-how-to-survive-test-driven-development/ We should make sure that whatever they were intended to test is covered by at least one of (1) talos performance tests, e.g. part of sunspider (2) non-time-dependent unit tests, e.g. based on jitstats and then remove the files.
(Tests disabled in http://hg.mozilla.org/mozilla-central/rev/06a14da370af)
Btw one of the tests was failing due to something actually being slower than it was supposed to be; see bug 482914.
(In reply to comment #1) > (Tests disabled in http://hg.mozilla.org/mozilla-central/rev/06a14da370af) Jesse, can you land this on 1.9.2 as well?
Created attachment 430156 [details] [diff] [review] 1.9.2 branch patch
do we need approval 1.9.2 for npotb test only changes?
Comment on attachment 430156 [details] [diff] [review] 1.9.2 branch patch Gavin Sharp says "test-only changes never require approval anywhere".
Tests disabled: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/52e50d6be739
You need to log in before you can comment on or make changes to this bug.