Replace bogus "timejit < timenonjit" tests

NEW
Unassigned

Status

()

--
minor
9 years ago
5 years ago

People

(Reporter: jruderman, Unassigned)

Tracking

(Depends on: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
I'm disabling a set of JS "unit tests" that were attempting to ensure the JIT was faster than the interpreter.  These tests were slow and failing intermittently.

Unit tests should never depend on timing:
http://joblivious.wordpress.com/2009/02/20/handling-intermittence-how-to-survive-test-driven-development/

We should make sure that whatever they were intended to test is covered by at least one of
  (1) talos performance tests, e.g. part of sunspider
  (2) non-time-dependent unit tests, e.g. based on jitstats
and then remove the files.
(Reporter)

Updated

9 years ago
Blocks: 540511
(Reporter)

Comment 2

9 years ago
Btw one of the tests was failing due to something actually being slower than it was supposed to be; see bug 482914.

Comment 3

9 years ago
(In reply to comment #1)
> (Tests disabled in http://hg.mozilla.org/mozilla-central/rev/06a14da370af)

Jesse, can you land this on 1.9.2 as well?
(Reporter)

Comment 4

9 years ago
Created attachment 430156 [details] [diff] [review]
1.9.2 branch patch
Attachment #430156 - Flags: approval1.9.2.2?

Comment 5

9 years ago
do we need approval 1.9.2 for npotb test only changes?
(Reporter)

Comment 6

9 years ago
Comment on attachment 430156 [details] [diff] [review]
1.9.2 branch patch

Gavin Sharp says "test-only changes never require approval anywhere".
Attachment #430156 - Flags: approval1.9.2.2?
(Reporter)

Updated

9 years ago
Depends on: 467263
Assignee: general → nobody
You need to log in before you can comment on or make changes to this bug.