Please remove "deliver mode" printf statement from nsMsgCompose::_SendMsg

RESOLVED FIXED in Thunderbird 6.0

Status

MailNews Core
Composition
RESOLVED FIXED
9 years ago
7 years ago

People

(Reporter: William Throwe, Assigned: Usul)

Tracking

Trunk
Thunderbird 6.0
Bug Flags:
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.6) Gecko/20100118 Gentoo IceCat/3.5.6 (like Firefox/3.5.6)
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091228 Shredder/3.0

nsMsgCompose::_SendMsg in mailnews/compose/src/nsMsgCompose.cpp contains a printf line which causes sending, autosaving, and similar actions to print "deliver mode:" and some number to the terminal if thunderbird was started from a terminal.  This is kind of annoying.

Please remove the printf or only enable it in debugging builds or something.

Reproducible: Always

Steps to Reproduce:
1. Send mail
2.
3.
Actual Results:  
deliver mode: 0
is printed to my terminal

Expected Results:  
Thunderbird shouldn't print anything to the terminal.
Blocks: 440794

Updated

9 years ago
Component: General → Composition
Product: Thunderbird → MailNews Core
QA Contact: general → composition
Summary: Please remove printf statement from nsMsgCompose::_SendMsg → Please remove "deliver mode" printf statement from nsMsgCompose::_SendMsg
Duplicate of this bug: 541440
(Assignee)

Comment 2

7 years ago
Created attachment 530025 [details] [diff] [review]
Cleaning up debug statements
Assignee: nobody → ludovic
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #530025 - Flags: review?(dbienvenu)

Comment 3

7 years ago
Comment on attachment 530025 [details] [diff] [review]
Cleaning up debug statements

that patch has a lot of extra junk in it - you might want to do a targeted diff.
Attachment #530025 - Flags: review?(dbienvenu) → review-
(Assignee)

Comment 4

7 years ago
Created attachment 530027 [details] [diff] [review]
[checked in] cleanup debug statments
Attachment #530025 - Attachment is obsolete: true
Attachment #530027 - Flags: review?(dbienvenu)

Comment 5

7 years ago
Comment on attachment 530027 [details] [diff] [review]
[checked in] cleanup debug statments

thx, rs=me
Attachment #530027 - Flags: review?(dbienvenu) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Comment on attachment 530027 [details] [diff] [review]
[checked in] cleanup debug statments

I've checked this in: http://hg.mozilla.org/comm-central/rev/944c4eb2a8ed

However, I've got a feeling comment 0 was referring to the #ifdef NS_DEBUG statements in that file, not just these old ones.
Attachment #530027 - Attachment description: cleanup debug statments → [checked in] cleanup debug statments
Keywords: checkin-needed
(Assignee)

Comment 7

7 years ago
The printf wasn't at all protected by DEBUG statements. I was unsure about the NS_DEBUG so I've left them. Want a followup patch to remove them ?
(Assignee)

Comment 8

7 years ago
David shall I also clean up the NS_DEBUGs ?

Comment 9

7 years ago
(In reply to comment #8)
> David shall I also clean up the NS_DEBUGs ?

sure, that would be great.
(Assignee)

Comment 10

7 years ago
Created attachment 530623 [details] [diff] [review]
Part 2 remove NS_DEBUG too
Attachment #530623 - Flags: review?(mbanner)
Version: unspecified → Trunk
Comment on attachment 530623 [details] [diff] [review]
Part 2 remove NS_DEBUG too

I'm happy, but want to check David is too.
Attachment #530623 - Flags: review?(mbanner) → review?(dbienvenu)

Comment 12

7 years ago
Comment on attachment 530623 [details] [diff] [review]
Part 2 remove NS_DEBUG too

yes, but these braces can go while you're at it:
   {
-#ifdef NS_DEBUG
-    printf("Failed to create mQuoteStreamListener\n");
-#endif
     return NS_ERROR_FAILURE;
   }
Attachment #530623 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 13

7 years ago
Created attachment 531928 [details] [diff] [review]
Part 2 remove NS_DEBUG too with r comments addressed

patch for checkin
Attachment #530623 - Attachment is obsolete: true
(Assignee)

Comment 14

7 years ago
Comment on attachment 531928 [details] [diff] [review]
Part 2 remove NS_DEBUG too with r comments addressed

carrying review flag
Attachment #531928 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Checked in:

http://hg.mozilla.org/comm-central/rev/330a00287b90
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-litmus-
Keywords: checkin-needed
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.4
You need to log in before you can comment on or make changes to this bug.