540892 - Stop using nsIDOMNode tree traversals

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Boris Zbarsky [:bzbarsky]]

One of the things that really slows down ApplyEventRules (apart from it being called too much and doing too much) is that it works on nsIDOMNodes.  In particular, nsCoreUtils::AreSiblings and nsCoreUtils::IsAncestorOf are fairly expensive operations involving a bunch of QI calls, refcounting, etc, etc.

This code should probably use nsINode instead.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Thanks! Assigning to Alexander after some IRC discussion. This seems well scoped and we'll do it for events as a first step.

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 422983 [details] [diff] [review]
patch

sr=bzbarsky

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 422983 [details] [diff] [review]
patch

r=me.

>@@ -1163,17 +1166,16 @@ nsRootAccessible::HandlePopupHidingEvent
>   if (comboboxRole == nsIAccessibleRole::ROLE_COMBOBOX ||
>       comboboxRole == nsIAccessibleRole::ROLE_AUTOCOMPLETE) {
>     nsRefPtr<nsAccEvent> event =
>       new nsAccStateChangeEvent(comboboxAcc,
>                                 nsIAccessibleStates::STATE_EXPANDED,
>                                 PR_FALSE, PR_FALSE);
>     NS_ENSURE_TRUE(event, NS_ERROR_OUT_OF_MEMORY);
> 
>-    nsRefPtr<nsAccessible> acc(nsAccUtils::QueryAccessible(comboboxAcc));

Aside: what was that line all about?

Comment 5

[alexander :surkov (:asurkov)]

(In reply to comment #4)

> Aside: what was that line all about?

It's rudiment from bug 5402727.

Comment 6

[alexander :surkov (:asurkov)]

(In reply to comment #5)
> (In reply to comment #4)
> 
> > Aside: what was that line all about?
> 
> It's rudiment from bug 5402727.

bug 540272

Comment 7

[alexander :surkov (:asurkov)]

landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/202a07f8110b