Closed Bug 541018 Opened 14 years ago Closed 14 years ago

pointer to NP_CGContext should be NULL in Cocoa event mode

Categories

(Core Graveyard :: Plug-ins, defect)

All
macOS
defect
Not set
normal

Tracking

(blocking2.0 beta1+)

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta1+

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(1 file)

In Cocoa event mode we give plugins a valid pointer to an NP_CGContext in the NPWindow structure sent to NPP_SetWindow. The NP_CGContext structure contains all NULL pointers, but we should really just be passing a NULL pointer for the NP_CGContext itself (no NP_CGContext at all).

While theoretically this shouldn't matter, I've already seen one plugin (Quicktime) misbehave because of a non-null pointer to the NP_CGContext and our behavior doesn't match WebKit or Chromium.
Attached patch fix v1.0Splinter Review
This totally fixes the problems with Quicktime not drawing on Mac OS X 10.6.
Attachment #423019 - Flags: review?(smichaud)
Comment on attachment 423019 [details] [diff] [review]
fix v1.0

This looks fine to me.
Attachment #423019 - Flags: review?(smichaud) → review+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/86a6b2485640
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: