541387 - [@ nsPop3IncomingServer::GetDeferredToAccount(nsACString_internal&)] Thunderbird will not start

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7 GTB6 (.NET CLR 3.5.30729)
Build Identifier: BuildID: 20100111101938

I auto-updated his morning from 3.0 to 3.01. Thunderbird will not start any more. I sometimes get a memory error (cannot read?), but not all the time. Goes to report screen, with these results:
Add-ons: {e2fda1a4-762b-4020-b5ad-a41df1933103}:1.0b1,{a62ef8ec-5fdc-40c2-873c-223b8a6925cc}:0.6b1,{972ce4c6-7e08-4474-a285-3208198ce6fd}:3.0.1
BuildID: 20100111101938
CrashTime: 1264174171
Email:xxxxxxxx@xxxxx
InstallTime: 1264150194
ProductName: Thunderbird
SecondsSinceLastCrash: 5709
StartupTime: 1264174167
Theme: classic/1.0
Throttleable: 1
URL: 

I have tried starting in safe mode, but exactly the same thing happens.

Reproducible: Always




I cannot now access my emails, business is sinking fast !

Comment 1

[[e-mail]]

Additional info on memory error
0x00487e66 at 0x0000000024 the memory could not be "read"

Comment 2

[Matthias Versen [:Matti]]

DO you already tried http://kb.mozillazine.org/Safe_mode ?
Do you get the Mozilla crash reporter after the crash ?

Comment 3

[[e-mail]]

Yes, I tried safe mode and the result is exactly the same.
Yes, I did get the crash report - visible details are shown above

Comment 4

[Matthias Versen [:Matti]]

We need the crash ID of the report.
You can find the ID if you follow https://developer.mozilla.org/en/How_to_get_a_stacktrace_for_a_bug_report#Accessing_crash_report_IDs_outside_of_Firefox (replace Firefox with Thunderbird in the path).

Can you please also try a new profile :
http://kb.mozillazine.org/Profile_Manager

Comment 5

[[e-mail]]

There are several crash reports, one of them is
Crash ID: bp-0d71f9e5-c481-499d-adba-000382100122

I have also tried a new profile, Thunderbird loaded, but crashed as soon as I copied the old profile data into the new profile directory

Comment 6

[Matthias Versen [:Matti]]

0  	thunderbird.exe  	nsPop3IncomingServer::GetDeferredToAccount  	 mailnews/local/src/nsPop3IncomingServer.cpp:227
1 	xpcom_core.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
2 	mozcrt19.dll 	operator new 	objdir-tb/mozilla/memory/jemalloc/src/new.cpp:54
3 	thunderbird.exe 	nsScriptSecurityManager::CanCreateWrapper 	caps/src/nsScriptSecurityManager.cpp:2898
4 	thunderbird.exe 	XPC_WN_CallMethod 	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1590

Comment 7

[timeless]

bienvenu@4604
225 rv = acctMgr->FindAccountForServer(localServer, getter_AddRefs(localAccount));

This returns NS_OK + nsnull

226 NS_ENSURE_SUCCESS(rv, rv);

this is the wrong check

227 localAccount->GetKey(aRetVal); 

this is the crash.

my tree isn't new enough to have this code.

Comment 8

[timeless]

Attachment: proposal

Comment 10

[Wayne Mery (:wsmwk)]

#32 crash for 3.0.1. all during startup

Comment 11

[Michael A. Pasek]

(In reply to comment #7)
> 226 NS_ENSURE_SUCCESS(rv, rv);
> 
> this is the wrong check

If that's the wrong check, what _should_ it be -- and why wasn't it changed in the proposed patch ?

Comment 12

[David :Bienvenu]

We should be checking for errors; the check isn't wrong; we just need the additional check

Comment 13

[Mark Banner (:standard8)]

Attachment: Document possible null return value.

I didn't want to hijack timeless' patch as I want to get that in for 3.0.2, but I will extend the bug - add a bit of documentation to indicate that FindAccountForServer may return null, so that callers can be aware if they look at the idl.

Comment 14

[Mark Banner (:standard8)]

Both patches checked in:
http://hg.mozilla.org/comm-central/rev/b353a7fb731d
http://hg.mozilla.org/comm-central/rev/0c73bb841289

Comment 15

[Mark Banner (:standard8)]

Comment on attachment 423322 [details] [diff] [review]
proposal

Low-risk obviously needed null-check patch. a=Standard8

Comment 16

[Mark Banner (:standard8)]

Comment on attachment 424570 [details] [diff] [review]
Document possible null return value.

Might as well take the comment-only documentation as well.

Comment 17

[Mark Banner (:standard8)]

Checked into 1.9.1 branch:
http://hg.mozilla.org/releases/comm-1.9.1/rev/2f13551589e4
http://hg.mozilla.org/releases/comm-1.9.1/rev/7a0516ecad29

Comment 18

[Ludovic Hirlimann [:Usul]]

Wayne can you verify this one please ?

Comment 19

[Wayne Mery (:wsmwk)]

Is this one of those problem where they see the crash only once?
Or, will reporter be able to verify problem is gone with newer build? 
 ftp://ftp.mozilla.org/pub/thunderbird/nightly/latest-comm-1.9.1/

Comment 20

[[e-mail]]

It crashes every time - I still can't user Thunderbird
If you have a compiled Windows version, I can try it out for you !

Comment 21

[Ludovic Hirlimann [:Usul]]

(In reply to comment #20)
> It crashes every time - I still can't user Thunderbird
> If you have a compiled Windows version, I can try it out for you !

have a look in http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/3.0.2-candidates/build1/win32/

Comment 22

[[e-mail]]

It works now, problem solved

Many thanks