Closed Bug 541446 Opened 11 years ago Closed 11 years ago

sort out details of where OOP minidumps should wind up

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a2
Tracking Status
status1.9.2 --- .4-fixed

People

(Reporter: ted, Assigned: ted)

References

Details

(Whiteboard: [fixed-lorentz])

Attachments

(2 files, 1 obsolete file)

bug 539843 adds an API to submit crash reports. It takes an "id" parameter, which it expects to be the filename (sans extension) of a minidump in the "Crash Reports/pending" directory. It's also, conveniently, the exact data I provide on the PluginCrashed event in my patch in bug 541076. However, currently the OOP crash reporting paths don't move the minidumps from $profile/minidumps to Crash Reports/pending, which means the crash reporting UI has to do it. (The temporary UI in oopcrashdialog.js does this right now.)

We can't simply have the C++ move them to pending always, because that will break the test harnesses' ability to notice crashes and display a stack. The test harnesses currently set MOZ_CRASHREPORTER_NO_REPORT=1 to suppress launching of the crash reporter, which is why the minidumps stay in $profile/minidumps. We can honor that variable in the OOP case, but that will make writing a browser-chrome test for plugin crash reporting difficult, since the minidump won't wind up in pending as expected.

I don't really know what the right solution is here. Perhaps honoring the env var, but also providing a way for individual tests to override that setting?
Ok, this does basically what I described. I included a test that verifies that unsetting MOZ_CRASHREPORTER_NO_REPORT in a mochitest will let a minidump produced in that test be moved to pending, so we can use that to write a browser-chrome test for dolske's UI.
Attachment #423037 - Flags: review?(benjamin)
If the diff looks wonky in bugzilla's diff viewer, it's because I "hg cp"ed test_crash_notify.xul to a new file.

Also, I did some gratuitous tab-removal in the Makefile.in.
Attachment #423037 - Flags: review?(benjamin) → review+
The test here depends on bug 541076.
Depends on: 541076
Updated to apply cleanly.
Attachment #423037 - Attachment is obsolete: true
Pushed http://hg.mozilla.org/mozilla-central/rev/748f275c6f1f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Flags: in-testsuite+
Comment on attachment 426271 [details] [diff] [review]
Leak quietly, rev. 1

We're leaking it either way, so whatever.
Attachment #426271 - Flags: review+
Depends on: 203764
In no way does this bug depend on bug 203764.
No longer depends on: 203764
Blanket approval for Lorentz merge to mozilla-1.9.2
a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed
Attachment #426100 - Attachment description: Patch v.2 → Patch v.2 [Checkin: Comment 5 & 12]
You need to log in before you can comment on or make changes to this bug.