Closed Bug 541446 Opened 12 years ago Closed 12 years ago
sort out details of where OOP minidumps should wind up
bug 539843 adds an API to submit crash reports. It takes an "id" parameter, which it expects to be the filename (sans extension) of a minidump in the "Crash Reports/pending" directory. It's also, conveniently, the exact data I provide on the PluginCrashed event in my patch in bug 541076. However, currently the OOP crash reporting paths don't move the minidumps from $profile/minidumps to Crash Reports/pending, which means the crash reporting UI has to do it. (The temporary UI in oopcrashdialog.js does this right now.) We can't simply have the C++ move them to pending always, because that will break the test harnesses' ability to notice crashes and display a stack. The test harnesses currently set MOZ_CRASHREPORTER_NO_REPORT=1 to suppress launching of the crash reporter, which is why the minidumps stay in $profile/minidumps. We can honor that variable in the OOP case, but that will make writing a browser-chrome test for plugin crash reporting difficult, since the minidump won't wind up in pending as expected. I don't really know what the right solution is here. Perhaps honoring the env var, but also providing a way for individual tests to override that setting?
Ok, this does basically what I described. I included a test that verifies that unsetting MOZ_CRASHREPORTER_NO_REPORT in a mochitest will let a minidump produced in that test be moved to pending, so we can use that to write a browser-chrome test for dolske's UI.
Attachment #423037 - Flags: review?(benjamin)
If the diff looks wonky in bugzilla's diff viewer, it's because I "hg cp"ed test_crash_notify.xul to a new file. Also, I did some gratuitous tab-removal in the Makefile.in.
Updated to apply cleanly.
Attachment #423037 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Comment on attachment 426271 [details] [diff] [review] Leak quietly, rev. 1 We're leaking it either way, so whatever.
Attachment #426271 - Flags: review+
Blanket approval for Lorentz merge to mozilla-1.9.2 a=beltzner for 220.127.116.11 - please make sure to mark status1.9.2:.4-fixed
Merged into 1.9.2 at http://hg.mozilla.org/releases/mozilla-1.9.2/rev/84ba4d805430
Attachment #426100 - Attachment description: Patch v.2 → Patch v.2 [Checkin: Comment 5 & 12]
You need to log in before you can comment on or make changes to this bug.