541660 - test_largeOfflineStore.js: Detect and exit early with non-NTFS volumes, and otherwise mark the inbox file as sparse on Windows

Status: RESOLVED FIXED

(MailNews Core :: Testing Infrastructure, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch, v1

FAT32 doesn't work with files above 4 GB, so we need to detect early and exit there.

Also, given that almost the entire file is empty, it seems like a waste to allocate space for it, so mark the file as sparse and the first 4 GB + change as a sparse region.

This doesn't need to be done on Linux, as the file system doesn't allocate space for untouched areas [1, 2]. On OS X, HFS+ doesn't support sparse files [1], so we still check for free space there -- apparently UFS does support sparse files, but I don't have OS X so I can't write a native code helper.

[1] http://stackoverflow.com/questions/186077/how-do-i-create-a-sparse-file-programmatically-in-c-on-mac-os-x

[2] http://www.win.tue.nl/~aeb/linux/lk/lk-6.html#ss6.2

Comment 1

[Rain [:rain1] (inactive)]

MSDN docs for sparse file operations: <http://msdn.microsoft.com/en-us/library/aa365566(VS.85).aspx>

Comment 2

[Rain [:rain1] (inactive)]

Attachment: patch, v1.001

Removed a dump statement and tweaked the position of an opening brace.

Comment 3

[David :Bienvenu]

We're eventually going to want something similar when we allow pop mailboxes > 4GB, so some or all of this might want to be in a shared place.

Comment 4

[Rain [:rain1] (inactive)]

Attachment: patch, v2

Yeah, I think I should have done that in the first place.

Comment 5

[Rain [:rain1] (inactive)]

Hm, I guess this'll need an ifdef ENABLE_TESTS around it in the makefile?

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 423148 [details] [diff] [review]
patch, v2

>@@ -51,16 +51,17 @@ PARALLEL_DIRS	+= \
...
>+	test \

This should be in a separate ifdef ENABLE_TESTS check.

>+    // XXX This needs to be fixed to use runw once it lands
>+    helperProc.run(true, args, args.length);

Nit: please include the bug number for this.

Comment 7

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/507ca7dafb29