541746 - [SeaMonkey 2.1] xpcshell: test_download_history.js and test_frecency.js fail, after bug 520165 landing

Status: VERIFIED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Serge Gautherie (:sgautherie)]

We fixed this test a year ago in bug 470707.
It now needs bug 520165 to be (fully) ported:
bug 536374 will fix this, but I file this separately due to ongoing test infrastructure changes...

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1264295815.1264297689.4981.gz&fulltext=1
Linux comm-central-trunk debug test xpcshell on 2010/01/23 17:16:55
{
TEST-UNEXPECTED-FAIL | test_download_history.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | test_download_history.js | true == false - See following stack:

JS frame :: xpcshell/head.js :: do_throw :: line 202
JS frame :: xpcshell/head.js :: do_check_eq :: line 232
JS frame :: xpcshell/head.js :: do_check_false :: line 251
JS frame :: test_download_history.js :: test_dh_disabledHistory :: line 122
JS frame :: test_download_history.js :: run_test :: line 154
JS frame :: xpcshell/head.js :: _execute_test :: line 130
JS frame :: -e :: <TOP_LEVEL> :: line 1
}

Code is
{
122   do_check_false(observer.topicReceived);
}

I reproduce this on my local non-packaged Windows opt build.

Comment 1

[Serge Gautherie (:sgautherie)]

test_frecency.js is in a "same" case.
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/unit/test_frecency.js

Comment 2

[Serge Gautherie (:sgautherie)]

As expected per bug 536374 comment 27:
*test_download_history.js is fixed.
*test_frecency.js still fails.

{
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1266513354.1266514667.21677.gz&fulltext=1
Linux comm-central-trunk debug test xpcshell on 2010/02/18 09:15:54

Test 8.1: same count, same date
TEST-PASS | tests/test_places/unit/test_frecency.js | [anonymous : 123] 1 == 1
TEST-PASS | test_places/unit/test_frecency.js | [anonymous : 127] 1 == 1
TEST-UNEXPECTED-FAIL | test_places/unit/test_frecency.js | 3 == 4 - See following stack:
JS frame :: xpcshell/head.js :: do_throw :: line 202
JS frame :: xpcshell/head.js :: do_check_eq :: line 232
JS frame :: test_places/unit/test_frecency.js :: anonymous :: line 129
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
JS frame :: seamonkey/components/nsPlacesAutoComplete.js :: PAC_notifyResults :: line 643
JS frame :: seamonkey/components/nsPlacesAutoComplete.js :: PAC_finishSearch :: line 590
JS frame :: seamonkey/components/nsPlacesAutoComplete.js :: PAC_handleCompletion :: line 501
JS frame :: seamonkey/components/nsPlacesAutoComplete.js :: ACSCW_handleCompletion :: line 176
}

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)

> TEST-UNEXPECTED-FAIL | test_places/unit/test_frecency.js | 3 == 4 - See
> following stack:
> JS frame :: test_places/unit/test_frecency.js :: anonymous :: line 129
> native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

It looks like we're getting "no match" instead of "match":
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/autocomplete/public/nsIAutoCompleteController.idl?mark=52-53#43

Ftr, we have some prefs at
http://mxr.mozilla.org/comm-central/source/suite/browser/browser-prefs.js#135
but not sure it is relevant in this case.

Comment 4

[Serge Gautherie (:sgautherie)]

MacOSX too:
{
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1266802005.1266803746.19182.gz
OS X 10.5 comm-central-trunk debug test xpcshell on 2010/02/21 17:26:45
}

Comment 5

[Serge Gautherie (:sgautherie)]

KaiRo, could you check this test?
(Hopefully, it's a preference issue as we're used to.)

Comment 6

[Robert Kaiser]

Attachment: fix test_frecency.js to work on SeaMonkey

test_download_history.js passes right here, perhaps it's a followup failure from something else or it's fixed by some of the other patches I have in my tree.
test_frecency.js needs the prefs set correctly apparently, though, this is a patch to apply the same fixes as I did on other tests, see e.g. http://hg.mozilla.org/mozilla-central/annotate/11798edae90d/toolkit/components/places/tests/unit/test_history_autocomplete_tags.js#l189

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> test_download_history.js passes right here

Yes, see comment 2.

Comment 8

[Robert Kaiser]

Pushed as http://hg.mozilla.org/mozilla-central/rev/1110220cedd4 - I think that should fix this.

Comment 9

[Serge Gautherie (:sgautherie)]

V.Fixed per tinderboxes.