Closed Bug 541770 Opened 12 years ago Closed 12 years ago

Cleanup js/src during make distclean

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch Patch (obsolete) — Splinter Review
A bunch of files are not cleaned up from js/src when doing make distclean.
Attachment #423211 - Attachment is patch: true
Attachment #423211 - Attachment mime type: application/octet-stream → text/plain
Attachment #423211 - Flags: review?(benjamin)
Attachment #423211 - Flags: review?(benjamin) → review?(ted.mielczarek)
Attached patch Patch v2 (obsolete) — Splinter Review
Even more cleanup
Assignee: nobody → mh+mozilla
Attachment #423211 - Attachment is obsolete: true
Attachment #424594 - Flags: review?(ted.mielczarek)
Attachment #423211 - Flags: review?(ted.mielczarek)
Attachment #424594 - Flags: review?(ted.mielczarek) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Blocks: 546642
Flags: in-testsuite-
Keywords: checkin-needed
OS: Linux → All
Hardware: x86 → All
Comment on attachment 424594 [details] [diff] [review]
Patch v2


This does not apply to m-c.
See discussion in bug 546642:
I can't believe it passed review, in both bugs :-<
Attachment #424594 - Attachment is obsolete: true
Attachment #424594 - Flags: review-
I'm sorry if your patch utility is unable to apply the patch, but apart from the line numbers and the context next to them, which are mostly irrelevant, the patch perfectly applies on m-c: it adds lines at the end of the file, after 3 endifs, which the file in m-c has.
And plain GNU patch manages to apply it:
Hunk #1 succeeded at 697 (offset 28 lines).
Oh I see now...
http://hg.mozilla.org/mozilla-central/rev/e3623a7d1217

D'oh....
mmmm... Note the file list is wrong there...
Attached patch PatchSplinter Review
Sorry I screwed up so badly this round. This patch is after the additional patch for js/src in bug 541767
Attachment #427932 - Flags: review?(sgautherie.bz)
Attachment #427932 - Flags: review?(sgautherie.bz) → review?(ted.mielczarek)
Attachment #427932 - Flags: review?(ted.mielczarek) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/b8b69fa241da
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.