Closed
Bug 541770
Opened 14 years ago
Closed 14 years ago
Cleanup js/src during make distclean
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 2 obsolete files)
|
332 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
A bunch of files are not cleaned up from js/src when doing make distclean.
|
Assignee | |
Updated•14 years ago
|
Attachment #423211 -
Attachment is patch: true
Attachment #423211 -
Attachment mime type: application/octet-stream → text/plain
Attachment #423211 -
Flags: review?(benjamin)
|
||
Updated•14 years ago
|
Attachment #423211 -
Flags: review?(benjamin) → review?(ted.mielczarek)
|
|
Assignee | |
Comment 1•14 years ago
|
||
Even more cleanup
Assignee: nobody → mh+mozilla
Attachment #423211 -
Attachment is obsolete: true
Attachment #424594 -
Flags: review?(ted.mielczarek)
Attachment #423211 -
Flags: review?(ted.mielczarek)
|
||
Updated•14 years ago
|
Attachment #424594 -
Flags: review?(ted.mielczarek) → review+
|
||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
||
Updated•14 years ago
|
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 424594 [details] [diff] [review] Patch v2 This does not apply to m-c. See discussion in bug 546642: I can't believe it passed review, in both bugs :-<
Attachment #424594 -
Attachment is obsolete: true
Attachment #424594 -
Flags: review-
|
|
Assignee | |
Comment 3•14 years ago
|
||
I'm sorry if your patch utility is unable to apply the patch, but apart from the line numbers and the context next to them, which are mostly irrelevant, the patch perfectly applies on m-c: it adds lines at the end of the file, after 3 endifs, which the file in m-c has.
|
|
Assignee | |
Comment 4•14 years ago
|
||
And plain GNU patch manages to apply it: Hunk #1 succeeded at 697 (offset 28 lines).
|
|
Assignee | |
Comment 5•14 years ago
|
||
Oh I see now... http://hg.mozilla.org/mozilla-central/rev/e3623a7d1217 D'oh.... mmmm... Note the file list is wrong there...
|
|
Assignee | |
Comment 6•14 years ago
|
||
Sorry I screwed up so badly this round. This patch is after the additional patch for js/src in bug 541767
Attachment #427932 -
Flags: review?(sgautherie.bz)
|
|
||
Updated•14 years ago
|
Attachment #427932 -
Flags: review?(sgautherie.bz) → review?(ted.mielczarek)
|
|
||
Updated•14 years ago
|
Attachment #427932 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/b8b69fa241da
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•