Closed Bug 541774 Opened 14 years ago Closed 14 years ago

idl-parser cache and compiled python files are not cleaned up by make clean

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(3 files)

Attached patch PatchSplinter Review
There are .pyc leftovers in other-licenses/ply/ply and xpcom/idl-parser, as well as cache files in the latter.

The attached patch moves the cache files to another directory, and removes the .pyc files.
Attachment #423213 - Attachment is patch: true
Attachment #423213 - Attachment mime type: application/octet-stream → text/plain
Attachment #423213 - Flags: review?(benjamin)
Attachment #423213 - Flags: review?(benjamin) → review?(ted.mielczarek)
Assignee: nobody → mh+mozilla
Attachment #423213 - Flags: review?(ted.mielczarek) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Attached patch Additional patchSplinter Review
Additional patch, required in some cases. I haven't looked deeply where that comes from, but seamonkey builds trigger the generation of the file.
The patch needs to be applied on top of the first one.
Attachment #427335 - Flags: review?(ted.mielczarek)
it comes from yacc, we specify it as a debugfile. And we do not override the default |debug=1| in yacc when we init that.

This file seems like it should also be present in the Firefox build too.
Attachment #427335 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/5c7b969a71fa
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269592638.1269594793.31262.gz

backed out
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch One more patchSplinter Review
This comes on top of the 2 others and should solve the problem.
Attachment #435130 - Flags: review?(ted.mielczarek)
Attachment #435130 - Flags: review?(ted.mielczarek) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/7a792c959553
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: mozilla1.9.3a4 → mozilla1.9.3a5
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: