541804 - infinite loop when a tree has a flex and a rows attribute

Status: NEW

(Core :: XUL, defect)

Description

[Malte Kraus]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.1pre) Gecko/20100123 Namoroka/3.6.1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.1pre) Gecko/20100123 Namoroka/3.6.1pre




Reproducible: Always

Steps to Reproduce:
1. Load a xul file with a tree with both a flex and a rows attribute.
2. Click the tree's column picker.
3. Instead of the column picker, invoking the tree editor or a context menu on the tree do the same thing.
Actual Results:  
One CPU core is maxed out. The UI remains responsive (at least on my quad core), but laggy.

Expected Results:  
Nothing of the above.

This worked fine in Firefox 3.5. Cost me a few hours to find out the problem is xul and not my tree view.

Comment 1

[Malte Kraus]

Attachment: test case

Comment 2

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20100123 Minefield/3.7a1pre

Confirmed and it is still happening with the latest trunk build.

Comment 3

[Neil Deakin]

I don't see any problem with this testcase on trunk or on 1.9.2.

Comment 4

[Malte Kraus]

Did you click the column picker?

Comment 5

[Matt]

I get a Regression range of:

works - CPU stays around 0%:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091021 Minefield/3.7a1pre
2009-10-21-03-mozilla-central

broken - CPU climbed to greater than 70% and stayed:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091022 Minefield/3.7a1pre
2009-10-22-03-mozilla-central

Comment 6

[George]

I have an add-on with basically same problem. If I click on a column header, cpu for Fx shoots to 50%, and stays until I either stretch the dialog until the tree size changes, or click on columnpicker. Also, if I display a tooltip for a nearby button that shows on top of the tree, triggers the same problem.
Removing rows attribute fixed this. As mentioned above, problem started with 3.6

Comment 8

[Timothy Nikkel (:tnikkel)]

Bisecting locally found the first bad changeset to be
http://hg.mozilla.org/mozilla-central/rev/f163afecb7c3
or bug 494901.

Comment 9

[Timothy Nikkel (:tnikkel)]

Running various things off the refresh driver since this bug first regressed probably means the CPU usage in current builds is lower.

Comment 10

[Neil Deakin]

This might be related to bug 617330.

Comment 11

[barstadd]

Appears to still be an issue after all these years with xulrunner 41!

With flex and rows attributes set (or row attribute set to a number smaller than the visible tree area) the treeview gets caught in an infinite loop invoking getColumnProperties(). Keeping the flex attribute and removing the rows attribute stops the infinite loop and behaves normally.  One could set the overall height of the tree's parent for example, in order not to set the rows attribute but still control the height of the tree.