541824 - Sort removed-files.in entries

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) components/* part [Checkin: Comment 4]

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 423238 [details] [diff] [review]
(Av1) components/* part
[Checkin: Comment 4]

"approval-seamonkey2.0.3=?":
Zero risk, keep c-1.9.1 in sync'.

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 423238 [details] [diff] [review]
(Av1) components/* part
[Checkin: Comment 4]

it is zero-risk; but not sure a sorting-only is worth moving to 2.0.3; but I won't block this review on said approval request

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 423238 [details] [diff] [review]
(Av1) components/* part
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/03524dcb2959

Comment 5

[Robert Kaiser]

Comment on attachment 423238 [details] [diff] [review]
(Av1) components/* part
[Checkin: Comment 4]

Nah, let's not touch 2.0.x where we don't have to.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I'm adding the ability to have indentation in Bug 555512 so you can take advantage of that if you'd like :-)

Comment 8

[Justin Wood (:Callek)]

(In reply to Bug 563275 comment #2)
> (In reply to Bug 563275 comment #0)
>
> > To directly outline the rules I wish to port:
> > 
> > "These files are in alphabetical order, except that files removed only on
> > certain platforms are after all of the regular files and obsolete Talkback and
> > Inspector files are at the very end."
> 
> I'm not sure I like this "except" part yet ... but alphab. order and
> indentation, sure.

I do feel that keeping all the if's at the end is the BEST choice. the "except" clause (e.g. talkback/inspector) might be best tweaked for /our/ needs though, rather than a direct copy of Firefox's.