542054 - Fix warning spam from jstypedarray.cpp (unsigned/signed comparison, control reaches end of non-void function)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Attachment: fix

When compiling jstypedarray.cpp, I get the following warning-spew:
{
../../../mozilla/js/src/jstypedarray.cpp: In member function ‘bool TypedArrayTemplate<NativeType>::copyFrom(JSContext*, JSObject*, jsuint) [with NativeType = signed char]’:
../../../mozilla/js/src/jstypedarray.cpp:707:   instantiated from ‘bool TypedArrayTemplate<NativeType>::init(JSContext*, JSObject*, int32, int32) [with NativeType = signed char]’
../../../mozilla/js/src/jstypedarray.cpp:573:   instantiated from ‘static JSBool TypedArrayTemplate<NativeType>::class_constructor(JSContext*, JSObject*, uintN, jsval*, jsval*) [with NativeType = signed char]’
../../../mozilla/js/src/jstypedarray.cpp:1144:   instantiated from here
../../../mozilla/js/src/jstypedarray.cpp:805: warning: comparison between signed and unsigned integer expressions
../../../mozilla/js/src/jstypedarray.cpp: In member function ‘bool TypedArrayTemplate<NativeType>::copyFrom(JSContext*, JSObject*, jsuint) [with NativeType = unsigned char]’:
../../../mozilla/js/src/jstypedarray.cpp:707:   instantiated from ‘bool TypedArrayTemplate<NativeType>::init(JSContext*, JSObject*, int32, int32) [with NativeType = unsigned char]’
../../../mozilla/js/src/jstypedarray.cpp:573:   instantiated from ‘static JSBool TypedArrayTemplate<NativeType>::class_constructor(JSContext*, JSObject*, uintN, jsval*, jsval*) [with NativeType = unsigned char]’
../../../mozilla/js/src/jstypedarray.cpp:1145:   instantiated from here
../../../mozilla/js/src/jstypedarray.cpp:805: warning: comparison between signed and unsigned integer expressions
../../../mozilla/js/src/jstypedarray.cpp: In member function ‘bool TypedArrayTemplate<NativeType>::copyFrom(JSContext*, JSObject*, jsuint) [with NativeType = short int]’:
../../../mozilla/js/src/jstypedarray.cpp:707:   instantiated from ‘bool TypedArrayTemplate<NativeType>::init(JSContext*, JSObject*, int32, int32) [with NativeType = short int]’
../../../mozilla/js/src/jstypedarray.cpp:573:   instantiated from ‘static JSBool TypedArrayTemplate<NativeType>::class_constructor(JSContext*, JSObject*, uintN, jsval*, jsval*) [with NativeType = short int]’
../../../mozilla/js/src/jstypedarray.cpp:1146:   instantiated from here
../../../mozilla/js/src/jstypedarray.cpp:805: warning: comparison between signed and unsigned integer expressions
../../../mozilla/js/src/jstypedarray.cpp: In member function ‘bool TypedArrayTemplate<NativeType>::copyFrom(JSContext*, JSObject*, jsuint) [with NativeType = short unsigned int]’:
../../../mozilla/js/src/jstypedarray.cpp:707:   instantiated from ‘bool TypedArrayTemplate<NativeType>::init(JSContext*, JSObject*, int32, int32) [with NativeType = short unsigned int]’
../../../mozilla/js/src/jstypedarray.cpp:573:   instantiated from ‘static JSBool TypedArrayTemplate<NativeType>::class_constructor(JSContext*, JSObject*, uintN, jsval*, jsval*) [with NativeType = short unsigned int]’
../../../mozilla/js/src/jstypedarray.cpp:1147:   instantiated from here
../../../mozilla/js/src/jstypedarray.cpp:805: warning: comparison between signed and unsigned integer expressions
../../../mozilla/js/src/jstypedarray.cpp: In member function ‘bool TypedArrayTemplate<NativeType>::copyFrom(JSContext*, JSObject*, jsuint) [with NativeType = int]’:
../../../mozilla/js/src/jstypedarray.cpp:707:   instantiated from ‘bool TypedArrayTemplate<NativeType>::init(JSContext*, JSObject*, int32, int32) [with NativeType = int]’
../../../mozilla/js/src/jstypedarray.cpp:573:   instantiated from ‘static JSBool TypedArrayTemplate<NativeType>::class_constructor(JSContext*, JSObject*, uintN, jsval*, jsval*) [with NativeType = int]’
../../../mozilla/js/src/jstypedarray.cpp:1148:   instantiated from here
../../../mozilla/js/src/jstypedarray.cpp:805: warning: comparison between signed and unsigned integer expressions
../../../mozilla/js/src/jstypedarray.cpp: In member function ‘bool TypedArrayTemplate<NativeType>::copyFrom(JSContext*, JSObject*, jsuint) [with NativeType = unsigned int]’:
../../../mozilla/js/src/jstypedarray.cpp:707:   instantiated from ‘bool TypedArrayTemplate<NativeType>::init(JSContext*, JSObject*, int32, int32) [with NativeType = unsigned int]’
../../../mozilla/js/src/jstypedarray.cpp:573:   instantiated from ‘static JSBool TypedArrayTemplate<NativeType>::class_constructor(JSContext*, JSObject*, uintN, jsval*, jsval*) [with NativeType = unsigned int]’
../../../mozilla/js/src/jstypedarray.cpp:1149:   instantiated from here
../../../mozilla/js/src/jstypedarray.cpp:805: warning: comparison between signed and unsigned integer expressions
../../../mozilla/js/src/jstypedarray.cpp: In member function ‘bool TypedArrayTemplate<NativeType>::copyFrom(JSContext*, JSObject*, jsuint) [with NativeType = float]’:
../../../mozilla/js/src/jstypedarray.cpp:707:   instantiated from ‘bool TypedArrayTemplate<NativeType>::init(JSContext*, JSObject*, int32, int32) [with NativeType = float]’
../../../mozilla/js/src/jstypedarray.cpp:573:   instantiated from ‘static JSBool TypedArrayTemplate<NativeType>::class_constructor(JSContext*, JSObject*, uintN, jsval*, jsval*) [with NativeType = float]’
../../../mozilla/js/src/jstypedarray.cpp:1150:   instantiated from here
../../../mozilla/js/src/jstypedarray.cpp:805: warning: comparison between signed and unsigned integer expressions
../../../mozilla/js/src/jstypedarray.cpp: In function ‘bool TypedArrayConstruct(JSContext*, jsint, uintN, jsval*, jsval*)’:
../../../mozilla/js/src/jstypedarray.cpp:1219: warning: control reaches end of non-void function
}

That's 5 instances of the same unsigned/signed comparison (with 5 lines for each of those warnings), plus one instance of a "control reaches end of non-void function" warning.

Fix attached.

Comment 1

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/635d36218771