Closed
Bug 542091
Opened 14 years ago
Closed 14 years ago
remove JS_PushArguments[VA]
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a2
People
(Reporter: luke, Assigned: luke)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(2 files)
17.28 KB,
patch
|
mrbkap
:
review+
dveditz
:
review+
|
Details | Diff | Splinter Review |
721 bytes,
patch
|
dveditz
:
review+
|
Details | Diff | Splinter Review |
It sounds like JS_PushArguments[VA] should have been part of the friend API since it uses js_AllocStack which allows callers to build an argument array for js_Invoke. Talking to Brendan, this function was initially used in xpconnect, but it doesn't seem to be used anymore in lieu of calling js_AllocStack directly. MXR shows only one use, in xpinstall, which is easy to avoid. JS_PushArguments's use of js_AllocStack interferes with changes to interpreter stack layout changes (bug 540706) underway, so this bug removes them.
Attachment #423428 -
Flags: review?(dveditz)
Attachment #423428 -
Flags: review?(brendan)
Updated•14 years ago
|
Attachment #423428 -
Flags: review?(brendan) → review?(mrbkap)
Updated•14 years ago
|
Attachment #423428 -
Flags: review?(mrbkap) → review+
Comment 1•14 years ago
|
||
Comment on attachment 423428 [details] [diff] [review] remove JS_PushArguments and caller in xpinstall r=dveditz
Attachment #423428 -
Flags: review?(dveditz) → review+
Assignee | ||
Comment 2•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/c6980db86452
Assignee: general → lw
Whiteboard: fixed-in-tracemonkey
Assignee | ||
Comment 3•14 years ago
|
||
Fixed build errors related to opt builds and x86-64: http://hg.mozilla.org/tracemonkey/rev/584af5971ccf http://hg.mozilla.org/tracemonkey/rev/6013a86204c2
Comment 4•14 years ago
|
||
This patch broke mingw compilation with error: xpinstall/src/nsXPITriggerInfo.cpp:253: error: invalid conversion from 'const PRUnichar*' to 'const jschar*' The attached patch fixes it. See bug 508905 for overview of the problem.
Updated•14 years ago
|
Attachment #428936 -
Flags: review?(dveditz)
Comment 5•14 years ago
|
||
Comment on attachment 428936 [details] [diff] [review] mingw fix r=dveditz
Attachment #428936 -
Flags: review?(dveditz) → review+
Updated•14 years ago
|
Keywords: checkin-needed
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c6980db86452
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•14 years ago
|
||
Thanks Jacek, pushed as: http://hg.mozilla.org/mozilla-central/rev/1a9ec95ea520
Updated•14 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•