Closed Bug 542091 Opened 10 years ago Closed 10 years ago
It sounds like JS_PushArguments[VA] should have been part of the friend API since it uses js_AllocStack which allows callers to build an argument array for js_Invoke. Talking to Brendan, this function was initially used in xpconnect, but it doesn't seem to be used anymore in lieu of calling js_AllocStack directly. MXR shows only one use, in xpinstall, which is easy to avoid. JS_PushArguments's use of js_AllocStack interferes with changes to interpreter stack layout changes (bug 540706) underway, so this bug removes them.
Attachment #423428 - Flags: review?(brendan) → review?(mrbkap)
Attachment #423428 - Flags: review?(mrbkap) → review+
Comment on attachment 423428 [details] [diff] [review] remove JS_PushArguments and caller in xpinstall r=dveditz
Attachment #423428 - Flags: review?(dveditz) → review+
Assignee: general → lw
Fixed build errors related to opt builds and x86-64: http://hg.mozilla.org/tracemonkey/rev/584af5971ccf http://hg.mozilla.org/tracemonkey/rev/6013a86204c2
This patch broke mingw compilation with error: xpinstall/src/nsXPITriggerInfo.cpp:253: error: invalid conversion from 'const PRUnichar*' to 'const jschar*' The attached patch fixes it. See bug 508905 for overview of the problem.
Comment on attachment 428936 [details] [diff] [review] mingw fix r=dveditz
Attachment #428936 - Flags: review?(dveditz) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Thanks Jacek, pushed as: http://hg.mozilla.org/mozilla-central/rev/1a9ec95ea520
Target Milestone: --- → mozilla1.9.3a2
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.