Closed Bug 542091 Opened 10 years ago Closed 10 years ago

remove JS_PushArguments[VA]

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a2

People

(Reporter: luke, Assigned: luke)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(2 files)

It sounds like JS_PushArguments[VA] should have been part of the friend API since it uses js_AllocStack which allows callers to build an argument array for js_Invoke.  Talking to Brendan, this function was initially used in xpconnect, but it doesn't seem to be used anymore in lieu of calling js_AllocStack directly.  MXR shows only one use, in xpinstall, which is easy to avoid.  JS_PushArguments's use of js_AllocStack interferes with changes to interpreter stack layout changes (bug 540706) underway, so this bug removes them.
Attachment #423428 - Flags: review?(dveditz)
Attachment #423428 - Flags: review?(brendan)
Attachment #423428 - Flags: review?(brendan) → review?(mrbkap)
Attachment #423428 - Flags: review?(mrbkap) → review+
Comment on attachment 423428 [details] [diff] [review]
remove JS_PushArguments and caller in xpinstall

r=dveditz
Attachment #423428 - Flags: review?(dveditz) → review+
http://hg.mozilla.org/tracemonkey/rev/c6980db86452
Assignee: general → lw
Whiteboard: fixed-in-tracemonkey
Attached patch mingw fixSplinter Review
This patch broke mingw compilation with error:

xpinstall/src/nsXPITriggerInfo.cpp:253: error: invalid conversion from 'const PRUnichar*' to 'const jschar*'

The attached patch fixes it. See bug 508905 for overview of the problem.
Blocks: 508905
Attachment #428936 - Flags: review?(dveditz)
Comment on attachment 428936 [details] [diff] [review]
mingw fix

r=dveditz
Attachment #428936 - Flags: review?(dveditz) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/c6980db86452
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3a2
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.