Closed Bug 542582 Opened 11 years ago Closed 10 years ago

pymake should support -s

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b4

People

(Reporter: sdwilsh, Assigned: Mitch)

References

Details

Attachments

(2 files, 1 obsolete file)

I don't need to see most of the output, and I used to always use make -s.  It'd be really useful to have a -s option in pymake too.
Attached patch unfinished patchSplinter Review
So here's an unfinished patch; the main reason is that in process.py, I couldn't figure out how to pass the config/options down to there so that I can do the right thing in _docall.  Right now it just hardcodes to never echo the command, and -s suppresses the directory enter/exit bits.
Blocks: 485412
Attached patch WIP (obsolete) — Splinter Review
I have no idea if this is the right approach or behaviour. It is what it is.
Attachment #462122 - Flags: feedback?(ted.mielczarek)
Attachment #462122 - Flags: feedback?(me)
Comment on attachment 462122 [details] [diff] [review]
WIP

>diff --git a/pymake/command.py b/pymake/command.py
>-                                          targets=self.targets, keepgoing=self.options.keepgoing)
>+                                          targets=self.targets, keepgoing=self.options.keepgoing, silent=self.options.silent)
The style here is ... interesting

Does make -s suppress just the echoing or the actual compiler output?
Attached patch Patch v1.1Splinter Review
This patch makes it so the "-s" option suppresses command echoing.
Assignee: nobody → mitchell.field
Attachment #462122 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #462152 - Flags: review?(me)
Attachment #462122 - Flags: feedback?(ted.mielczarek)
Attachment #462122 - Flags: feedback?(me)
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/7372f485a5ca
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
m-c will pick it up the next time we update.
Target Milestone: mozilla2.0b4 → ---
Which just happened.
Target Milestone: --- → mozilla2.0b4
The latest snapshot was backed out a while ago, so I pushed this singly.

http://hg.mozilla.org/mozilla-central/rev/232553f741a0
Depends on: 746488
No longer depends on: 746488
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.