pymake should support -s

RESOLVED FIXED in mozilla2.0b4

Status

()

Core
Build Config
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: sdwilsh, Assigned: Mitch)

Tracking

unspecified
mozilla2.0b4
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

7 years ago
I don't need to see most of the output, and I used to always use make -s.  It'd be really useful to have a -s option in pymake too.
Created attachment 431252 [details] [diff] [review]
unfinished patch

So here's an unfinished patch; the main reason is that in process.py, I couldn't figure out how to pass the config/options down to there so that I can do the right thing in _docall.  Right now it just hardcodes to never echo the command, and -s suppresses the directory enter/exit bits.
(Assignee)

Updated

7 years ago
Blocks: 485412
(Assignee)

Comment 2

7 years ago
Created attachment 462122 [details] [diff] [review]
WIP

I have no idea if this is the right approach or behaviour. It is what it is.
Attachment #462122 - Flags: feedback?(ted.mielczarek)
Attachment #462122 - Flags: feedback?(me)
Comment on attachment 462122 [details] [diff] [review]
WIP

>diff --git a/pymake/command.py b/pymake/command.py
>-                                          targets=self.targets, keepgoing=self.options.keepgoing)
>+                                          targets=self.targets, keepgoing=self.options.keepgoing, silent=self.options.silent)
The style here is ... interesting

Does make -s suppress just the echoing or the actual compiler output?
(Assignee)

Comment 4

7 years ago
Created attachment 462152 [details] [diff] [review]
Patch v1.1

This patch makes it so the "-s" option suppresses command echoing.
Assignee: nobody → mitchell.field
Attachment #462122 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #462152 - Flags: review?(me)
Attachment #462122 - Flags: feedback?(ted.mielczarek)
Attachment #462122 - Flags: feedback?(me)
Attachment #462152 - Flags: review?(me) → review+
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/7372f485a5ca
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
m-c will pick it up the next time we update.
Target Milestone: mozilla2.0b4 → ---
Which just happened.
Target Milestone: --- → mozilla2.0b4
(Assignee)

Comment 8

7 years ago
The latest snapshot was backed out a while ago, so I pushed this singly.

http://hg.mozilla.org/mozilla-central/rev/232553f741a0

Updated

5 years ago
Depends on: 746488
No longer depends on: 746488
You need to log in before you can comment on or make changes to this bug.