Block YSlow v. 2.0.5 for Fx 3.5 and 3.6

RESOLVED FIXED

Status

()

Toolkit
Blocklisting
--
blocker
RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: damons, Assigned: morgamic)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
Need to block version 2.0.5 of this addon:

https://addons.mozilla.org/en-US/firefox/addon/5369

Version 2.0.5 has caused a massive spike in multiple crashes, currently 2.4% of all crashes are caused by this addon.  Need to block it immediately.

Please call me if there are any questions.
(Assignee)

Updated

7 years ago
Assignee: nobody → morgamic
Status: NEW → ASSIGNED
(Assignee)

Comment 1

7 years ago
Going to just hard block yslow 2.0.5 for Firefox versions > 3.5.7.
(Assignee)

Comment 2

7 years ago
Are we blocking everything below 2.0.5 too or just that version specifically?
(Assignee)

Comment 3

7 years ago
I'll block 2.0.5 for now and expand it later if we need to.
(Assignee)

Comment 4

7 years ago
Resulting blocklist XML:
    <emItem id="yslow@yahoo-inc.com">
      <versionRange minVersion=" 2.0.5" maxVersion="2.0.5">
        <targetApplication id="{ec8030f7-c20a-464f-9b0e-13a3a9e97384}">
           <versionRange minVersion="3.5.7" maxVersion="*"/>
        </targetApplication>
      </versionRange>
    </emItem>

Query:
INSERT INTO `blitems` (`guid`, `min`, `max`) 
VALUES ('yslow@yahoo-inc.com', '2.0.5', '2.0.5');
INSERT INTO `blapps` (`blitem_id`, `guid`, `min`, `max`) VALUES ((SELECT MAX(id) FROM blitems), '{ec8030f7-c20a-464f-9b0e-13a3a9e97384}', '3.5.7', '*');
(Assignee)

Comment 5

7 years ago
This was run and is in production now:
https://addons.mozilla.org/blocklist/1/%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D/3.0b1/?omgpeanuts

I'll push the mozilla.com blocklist info.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Did we tell the YSlow team we were doing this?
(Assignee)

Comment 7

7 years ago
It's a known issue.  Mike, Mike or Damon can answer about outreach though.
Yeah, I know it's a known issue, and have been on the email thread with the developers about it. I'm wondering if there is another thread where we discussed this with them, since it wasn't on the one I'm on.
(Assignee)

Comment 9

7 years ago
Yeah, I know you know it's a known issue and I'm pretty sure they talked to them about it.
(Assignee)

Comment 10

7 years ago
Mike/Damon -- did we let them know, or is this just your decision from a Firefox perspective?
(Might need to call him, per comment 0.)
(In reply to comment #4)
>       <versionRange minVersion=" 2.0.5" maxVersion="2.0.5">

Is the space in the minVersion attribute harmful?
Ah, it's auto-generated. Nevermind.
(Assignee)

Comment 14

7 years ago
Shouldn't be there -- will take a look.
Product: addons.mozilla.org → Toolkit
You need to log in before you can comment on or make changes to this bug.