542738 - nsLocalFile::IsWritable/IsReadable/IsExecutable is wrong on Solaris

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Ginn Chen]

It is also wrong on BeOS.
But I'll only fix it for Solaris here.

The behavior is changed in Bug 351950, it explains why using access() is not good on Solaris.
The comment said Bug 351595, it is a typo.

Comment 1

[ISHIKAWA, Chiaki]

(In reply to comment #0)
> It is also wrong on BeOS.
> But I'll only fix it for Solaris here.
> 
> The behavior is changed in Bug 351950, it explains why using access() is not
> good on Solaris.
> The comment said Bug 351595, it is a typo.

Thanks. Now I understand what the issue was, I think. I guess we need to
fix the typo in the said also!

TIA

Comment 2

[Ginn Chen]

Attachment: patch

The BeOS implementation is not correct, it is better than nothing, since access() is always 0 on BeOS according to Bug 169506.

On Solaris, the only problem we want to resolve if IsExecutable()  with root user.
Using BeOS implementation is actually a step backwards.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 423978 [details] [diff] [review]
patch

This makes solaris work more like linux with the exception of IsExecutable().  That sounds fine to me.  Please make sure that you run the tests and nothing is an issue.

Comment 4

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/66aba5fa9dec