542817 - [mozmill] Remove attendees not working in Event modification test

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Merike Sell (:merike)]

Event modification test from bug 535812 fails on Mac per bug 535812#c7. Needs investigation if this is Mozmill only or a bug in Lightning.

Comment 1

[Harshitha]

testing

Comment 2

[Markus Adrario [:Taraman]]

Meanwhile, the test is repaired.
Only thing is that the attendees are failing the test when changed, so they are excluded at tho moment.

I believe it is the way they are set in testing is the reason (I can't make the context menu work and have to work around by deleting attendees via JS directly).

So I change the Summary to reflect the new situation and have a look at it.

Comment 3

[Markus Adrario [:Taraman]]

Attachment: eventMod.diff

I finally figured out, that a link to the attendee Object has to be added to the Menulist.
Noramally this is done on rightclick, but for some reason it isn't when being opened by mozmill. So we do this manually.

Now the Test works as intended.

Try-Run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=f2ef5125e28871050416bac638604ec2b07c1bf9

Comment 4

[Geoff Lankow (:darktrojan)]

That's weird. Is the object set when not in a test? Is it just a case of waiting for it?

I'd rather not hack a test together like that if we don't have to.

Comment 5

[Markus Adrario [:Taraman]]

When rightclicking "manually", everything works fine.

in the test I tried everything from clicking the entry beforehand, to waiting and every combination of calling the menu I could think of.

For some reason, in the Test it just doesn't work.
Finally, I found no other solution than this hack. :-(

The last thing I can think of is to try to add some logging code to lightning-item-iframe.js to try to find out what is missing when in a test...

Comment 6

[Geoff Lankow (:darktrojan)]

In lightning-item-iframe.xul, change the onclick attribute to oncontextmenu, and it works properly. Apparently the rightClick function doesn't send a click event with button = 2.

Comment 7

[Markus Adrario [:Taraman]]

Fascinating!

Shall I add that change in this Bug?

Comment 8

[Geoff Lankow (:darktrojan)]

Yes.

Comment 9

[Markus Adrario [:Taraman]]

Attachment: Fix V2

Now test working with "oncontextmenu"

Try-Run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=6191a227d70bd5a7a1bac557e0517091a83b598b

Comment 10

[Geoff Lankow (:darktrojan)]

Comment on attachment 9052737 [details] [diff] [review]
Fix V2

Review of attachment 9052737 [details] [diff] [review]:
-----------------------------------------------------------------

Nice one.

Comment 11

[Geoff Lankow (:darktrojan)]

Pre-emptively setting checkin-needed, as the Try run is still going.

Comment 12

[Markus Adrario [:Taraman]]

As the trybuilds all failed in the build stage, traing again:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=dc1449c84b6764b76ab1023260301d6fce00af25

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fc995375f444
[mozmill] Remove attendees not working in Event modification test. r=darktrojan