542912 - Refactor the newline handling behavior in nsTextEditRules

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

This patch refactors out the newline handling behavior in nsTextEditRules, and also makes FillBufWithPWChars accessible to outside callers.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 424148 [details] [diff] [review]
Patch (v1)

+  /**
+   * Handles the newline characters either according to aNewLineHandling
+   * or to the default system prefs if aNewLineHandling is negative.
+   */

Can you document what aNewLineHandling is allowed to be, and what those values do to aString?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 424148 [details] [diff] [review]
Patch (v1)

>+++ b/editor/libeditor/text/nsPlaintextEditor.cpp
>+nsPlaintextEditor::GetDefaultEditorPrefs(PRInt32 &aNewlineHandling,

If the prefs are not set, this function doesn't change its inout params.  It should probably set them to the default values nsPlaintextEditor uses instead.

>+++ b/editor/libeditor/text/nsTextEditRules.h
>+  /** Echoes the insertion text into the password buffer, and converts
>+      insertion text to '*'s */                                        

This doesn't make any sense.  What does this function actually do?

r=me with those two things fixed.

Comment 3

[(no longer active)]

Attachment: Patch (v1)

(In reply to comment #1)
> (From update of attachment 424148 [details] [diff] [review])
> +  /**
> +   * Handles the newline characters either according to aNewLineHandling
> +   * or to the default system prefs if aNewLineHandling is negative.
> +   */
> 
> Can you document what aNewLineHandling is allowed to be, and what those values
> do to aString?

Done.

(In reply to comment #2)
> (From update of attachment 424148 [details] [diff] [review])
> >+++ b/editor/libeditor/text/nsPlaintextEditor.cpp
> >+nsPlaintextEditor::GetDefaultEditorPrefs(PRInt32 &aNewlineHandling,
> 
> If the prefs are not set, this function doesn't change its inout params.  It
> should probably set them to the default values nsPlaintextEditor uses instead.

Done.

> >+++ b/editor/libeditor/text/nsTextEditRules.h
> >+  /** Echoes the insertion text into the password buffer, and converts
> >+      insertion text to '*'s */                                        
> 
> This doesn't make any sense.  What does this function actually do?

I documented this function in a saner way.

Updated patch attached.

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/d5e4ed59c450