542950 - [SeaMonkey trunk] mochitest-browser-chrome: new test fails with "browser_bug511456.js:99 - TypeError: win2 is undefined", browser_bug537449.js fails too

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1264710399.1264712477.16335.gz
Linux comm-central-trunk debug test mochitest-other on 2010/01/28 12:26:39
{
Chrome file doesn't exist: /builds/slave/comm-central-trunk-linux-debug-unittest-mochitest-other/build/mochitest/browser/toolkit/components/startup/tests/browser/head.js
[...]
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/startup/tests/browser/browser_bug511456.js | Exception thrown at chrome://mochikit/content/browser/toolkit/components/startup/tests/browser/browser_bug511456.js:99 - TypeError: win2 is undefined
}

browser_bug537449.js reports 5 'TEST-UNEXPECTED-FAIL' too!

Both fail since checked in.

Comment 1

[Philip Chee]

OpenBrowserWindow() is defined in SeaMonkey so I don't see why these tests are failing. Wrong scope perhaps?

Comment 2

[Justin Wood (:Callek)]

(In reply to comment #1)
> OpenBrowserWindow() is defined in SeaMonkey so I don't see why these tests are
> failing. Wrong scope perhaps?

Not wrong scope, SeaMonkey just doesn't return a useable window from OpenBrowserWindow().

http://mxr.mozilla.org/comm-central/source/suite/common/tasksOverlay.js#171

Comment 3

[Philip Chee]

These two tests already have a handle on nsIWindowWatcher. So they could just do something like:

http://mxr.mozilla.org/comm-central/source/suite/common/src/nsSessionStore.js#2391

    var argString = Components.classes["@mozilla.org/supports-string;1"]
                              .createInstance(Components.interfaces.nsISupportsString);
    argString.data = "about:blank";

    var win2 = wm.openWindow(null, this._prefBranch.getCharPref("chromeURL"), "_blank",
                             "chrome,dialog=no,all", argString);

Comment 4

[Dave Townsend [:mossop]]

(In reply to comment #3)
> These two tests already have a handle on nsIWindowWatcher. So they could just
> do something like:
> 
> http://mxr.mozilla.org/comm-central/source/suite/common/src/nsSessionStore.js#2391
> 
>     var argString = Components.classes["@mozilla.org/supports-string;1"]
>                              
> .createInstance(Components.interfaces.nsISupportsString);
>     argString.data = "about:blank";
> 
>     var win2 = wm.openWindow(null, this._prefBranch.getCharPref("chromeURL"),
> "_blank",
>                              "chrome,dialog=no,all", argString);

Want to file that in patch form?

Comment 5

[Philip Chee]

Attachment: Patch v1.0 Use ww.openWindow()

> Want to file that in patch form?
Sure.

Comment 6

[Philip Chee]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/f17c85b40f0f