542955 - personas -moz-lwtheme toolbar CSS applies to extension toolbars

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[mcdavis941 (sporadically reading bugmail)]

Some of the CSS rules for styling toolbox and toolbar in the -moz-lwtheme case are applying to FireBUG UI, and the effect isn't great.  The rules are written to apply to all toolbars everywhere, so they do.  Firebug can override this in its own CSS, but I'm wondering if those rules could or should be scoped so they only apply to toolboxen / toolbars in chrome up at the top of the browser window.

This is seen on Windows with Fx3.6 and Firebug 1.5 for sure, maybe other platforms too.

In winstripe/toolbar.css, from Bug 513461:

toolbox:-moz-lwtheme,
toolbar:-moz-lwtheme {
  -moz-appearance: none;
  background: none;
  border-style: none;
}

Firebug is the only place I've seen it so far, but it seems like it could show up in other extensions too.  There's a potential for the same issue with other elements receiving -moz-lwtheme styling in toolkit CSS.

(Are personas / lightweight themes conceived as features of Firefox and Thunderbird only, or are they intended to work with any toolkit-based app?  Or is this still TBD?)

STR:

1. Run Fx3.6 on Windows with Firebug 1.5
2. Open Firebug for any tab, select the Firebug "Console" panel
3. In Firebug, make sure the Console panel is enabled/activated
4. Install a persona which has a dark background, such as Japanese Tattoo (my personal favorite)

Comment 1

[mcdavis941 (sporadically reading bugmail)]

(In reply to comment #0)
> scoped so they
> only apply to toolboxen / toolbars in chrome up at the top of the browser
> window.

Or in the statusbar area.

Comment 2

[mcdavis941 (sporadically reading bugmail)]

Attachment: screenshot of issue

Comment 3

[Dão Gottwald [:dao]]

As far as I can see, this is all chrome and has nothing to do with the content area.

Comment 4

[mcdavis941 (sporadically reading bugmail)]

(In reply to comment #3)
> As far as I can see, this is all chrome and has nothing to do with the content
> area.

OK, agree.  In terms of representation, the toolbar is not in a document loaded in a <browser> element.

Visually, it's in a part of the overall browser window which personas are not yet (as far as I know) intended to style.

Comment 5

[Mark Banner (:standard8)]

We stopped calling the theme based "Personas" that name several years back, when they were also integrated into normal themes in Firefox.

Therefore bulk-closing Persona related bugs as they are no longer valid. If you are still having a potentially related issue in the latest version of Firefox, please take a look on our support site (https://support.mozilla.org) or file a new issue.