54296 - Can not span a cell in two columns using table properties dialog

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[bijals (gone)]

Steps:
1) Open a blank composer document
2) Insert default table
3) Click in top left cell
4) Click the table toolbar icon to get table/cell properites dialog
5) Click on span cell option and try to type "2"

Actual Results: Span cells text field is not enabled and does not work.  We
should not expose functionality that does not work in the UI.

Expected Results: Able to span cell to 2 columns

Build Date/Platform: 2000092608 using NT

Comment 1

[Charles Manske]

Darn! Simple problem: Apparently we must use 'removeAttribute("disabled")'
not 'setAttribute("disabled", "false")' to enable the textfield (I don't 
think that was always true!).
I'll attach the fix.

Comment 2

[Charles Manske]

Attachment: Fix for the bug

Comment 3

[Charles Manske]

Using the existing utility method "SetElementEnabledById", which is used
in most other instances of enabling/disabling, is the safe way to fix this.
This is very safe and simple, and without it, you can't set colspan or
rowspan in the Table Properties dialog, thus it's a good rtm candidate.
Reassigning to brade to checkin the fix since I'm starting sabatical soon.
This is *not* fixed in the trunk.

Comment 4

[rubydoo123]

all items within dialogs need to be functional for rtm

Comment 5

[rubydoo123]

Kathy, please include the required information per the rtm checkin rules

Comment 6

[Kathleen :Brade]

Attachment: attach a diff file with a fix

Comment 7

[Simon Fraser [no longer active]]

sr=sfraser on the diff.

Comment 8

[kinmoz]

sr=kin

Comment 9

[rubydoo123]

ok, this is super reviewed and btw they are module owner approvers too, removing 
need info and sending off to pdt

Comment 10

[Phil Peterson]

PDT marking [rtm++]

Comment 11

[Kathleen :Brade]

fix is checked into the branch

Comment 12

[sujay]

verified in 10/5 build