Can not span a cell in two columns using table properties dialog

VERIFIED FIXED

Status

()

Core
Editor
P2
normal
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: bijals (gone), Assigned: Kathleen Brade)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [rtm++][p:2])

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
Steps:
1) Open a blank composer document
2) Insert default table
3) Click in top left cell
4) Click the table toolbar icon to get table/cell properites dialog
5) Click on span cell option and try to type "2"

Actual Results: Span cells text field is not enabled and does not work.  We
should not expose functionality that does not work in the UI.

Expected Results: Able to span cell to 2 columns

Build Date/Platform: 2000092608 using NT

Comment 1

18 years ago
Darn! Simple problem: Apparently we must use 'removeAttribute("disabled")'
not 'setAttribute("disabled", "false")' to enable the textfield (I don't 
think that was always true!).
I'll attach the fix.
Assignee: beppe → cmanske
Keywords: correctness, rtm
Target Milestone: --- → M19

Comment 2

18 years ago
Created attachment 15666 [details] [diff] [review]
Fix for the bug

Comment 3

18 years ago
Using the existing utility method "SetElementEnabledById", which is used
in most other instances of enabling/disabling, is the safe way to fix this.
This is very safe and simple, and without it, you can't set colspan or
rowspan in the Table Properties dialog, thus it's a good rtm candidate.
Reassigning to brade to checkin the fix since I'm starting sabatical soon.
This is *not* fixed in the trunk.

Assignee: cmanske → brade

Comment 4

18 years ago
all items within dialogs need to be functional for rtm
Priority: P3 → P2
Whiteboard: [rtm+][p:2]

Comment 5

18 years ago
Kathy, please include the required information per the rtm checkin rules
Whiteboard: [rtm+][p:2] → [rtm+ NEED INFO][p:2]
(Assignee)

Comment 6

17 years ago
Created attachment 15975 [details] [diff] [review]
attach a diff file with a fix

Comment 7

17 years ago
sr=sfraser on the diff.

Comment 8

17 years ago
sr=kin

Comment 9

17 years ago
ok, this is super reviewed and btw they are module owner approvers too, removing 
need info and sending off to pdt
Whiteboard: [rtm+ NEED INFO][p:2] → [rtm+][p:2]

Comment 10

17 years ago
PDT marking [rtm++]
Whiteboard: [rtm+][p:2] → [rtm++][p:2]
(Assignee)

Comment 11

17 years ago
fix is checked into the branch
Status: NEW → RESOLVED
Last Resolved: 17 years ago
OS: Windows NT → All
Hardware: PC → All
Resolution: --- → FIXED

Comment 12

17 years ago
verified in 10/5 build
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.