Closed Bug 543060 Opened 14 years ago Closed 14 years ago

remove fennec's dependency on xulrunner

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: blassey, Assigned: blassey)

Details

Attachments

(1 file, 4 obsolete files)

Attached patch patch (obsolete) — Splinter Review
we seem to be moving away from the idea of having a useful system xulrunner, so let's not build it.
Attachment #424274 - Flags: review?(mark.finkle)
I noted this on IRC, but Firefox supports being built as a standalone app or --with-libxul-sdk, and Fennec should do the same.
Assignee: nobody → bugmail
Attached patch patch v.2 (obsolete) — Splinter Review
based on ted's suggestion. This patch works both ways, based on --with-libxul-sdk being passed to configure.
Attachment #424274 - Attachment is obsolete: true
Attachment #424289 - Flags: review?(mark.finkle)
Attachment #424274 - Flags: review?(mark.finkle)
Attached patch patch v.3 (obsolete) — Splinter Review
we only export an import library for windows, os2 and wince bugs.
Attachment #424289 - Attachment is obsolete: true
Attachment #425225 - Flags: review?(mark.finkle)
Attachment #424289 - Flags: review?(mark.finkle)
Attached patch patch to fix installer (obsolete) — Splinter Review
the 7zip installer assumes a few things are in dist/fennec/xulrunner, this fixes that assumption.

Also, I rearranged things a bit to make them readable
Attachment #425358 - Flags: review?(mark.finkle)
Attached patch patch v.4Splinter Review
this runs on linux as long as you packages it (having fennec sym-linked to $(srcdir)/mobile/app/fennec makes us not find the application.ini because its in the objdir) and run it with:

./run-mozilla.sh ./fennec
Attachment #425225 - Attachment is obsolete: true
Attachment #425358 - Attachment is obsolete: true
Attachment #428668 - Flags: review?(mark.finkle)
Attachment #425225 - Flags: review?(mark.finkle)
Attachment #425358 - Flags: review?(mark.finkle)
Comment on attachment 428668 [details] [diff] [review]
patch v.4

Tested on Maemo and it built with and without the libxul-sdk.

if we decide to use this for Maemo, we'll need to update the fennec.desktop.in file so it is aware of the | ./run-mozilla.sh ./fennec | issue.

File as a followup bug?

Nice patch
Attachment #428668 - Flags: review?(mark.finkle) → review+
pushed http://hg.mozilla.org/mobile-browser/rev/7227b5b43ebe
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: