Closed Bug 543150 Opened 14 years ago Closed 14 years ago

Eliminate platform.ini checking in XRE_main

Categories

(Toolkit :: Startup and Profile System, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mwu, Assigned: mwu)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [ts])

Attachments

(1 file, 1 obsolete file)

platform.ini is read in XRE_main for the buildid and milestone. Build ID and milestone should be determined at compile time since there's no reason to change the build id and milestone - it is what it is.
Attachment #424356 - Flags: review?(ted.mielczarek)
I think you should have bsmedberg's blessing before doing this. Also, we probably have build automation that relies on having platform.ini around nowadays.
Comment on attachment 424356 [details] [diff] [review]
Build in gToolkitVersion and gToolkitBuildID

This doesn't remove platform.ini.. it just makes reading platform.ini unnecessary to startup. It doesn't seem to me that the build id and milestone should be editable after build, so compiling these values in makes startup more robust without any downsides.
Attachment #424356 - Flags: review?(benjamin)
Comment on attachment 424356 [details] [diff] [review]
Build in gToolkitVersion and gToolkitBuildID

Need to work on this a bit more.
Attachment #424356 - Attachment is obsolete: true
Attachment #424356 - Flags: review?(ted.mielczarek)
Attachment #424356 - Flags: review?(benjamin)
Blocks: 447581
Blocks: android
Attachment #435026 - Flags: review?(benjamin)
OS: Android → All
Comment on attachment 435026 [details] [diff] [review]
Build in gToolkitVersion and gToolkitBuildID, v2

Please use := instead of =, so we don't run those $(shell) commands over and over again.
Attachment #435026 - Flags: review?(benjamin) → review+
Thanks for the review!

http://hg.mozilla.org/mozilla-central/rev/5f626bbd860a
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Depends on: 562045
Comment on attachment 435026 [details] [diff] [review]
Build in gToolkitVersion and gToolkitBuildID, v2

>+$(srcdir)/nsAppRunner.cpp: $(DEPTH)/config/buildid $(topsrcdir)/config/milestone.txt
This isn't going to work. Did you mean to make nsAppRunner.$(OBJ_SUFFIX) depend on the build ID and milestone instead?
Depends on: 729488
You need to log in before you can comment on or make changes to this bug.