[dashboard][shipping] pushes view should show check-in comment instead of changeset revision

RESOLVED FIXED

Status

Mozilla Localizations
Infrastructure
P2
normal
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Pike, Assigned: gandalf)

Tracking

({polish})

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

8 years ago
I thought we had a bug for this, but apparently we don't, getting one on file.

The revisions that we show on the pushes view are not so helpful to people, it'd be much better if we showed the first line of the comment instead. Maybe truncate the comment, too.

If the comment is truncated, we could probably do something similar to the jquery.ui accordion, but not that. http://jqueryui.com/demos/accordion/ has pointers.

Calling this a P2, and polish.
(Assignee)

Updated

8 years ago
Assignee: nobody → gandalf
(Assignee)

Comment 1

8 years ago
fxd: http://hg.mozilla.org/l10n/django-site/rev/0566c3dd53ba
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

8 years ago
I'd be surprised if that wasn't susceptible to xml markup etc in the revdesc. Shouldn't .text(push.revdesc) be safter?

Also, we should probably do something in the case of really lengthy comments, like http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/he/rev/f2ec5d9e8e3b
(Reporter)

Updated

8 years ago
Depends on: 545505
You need to log in before you can comment on or make changes to this bug.