I'm usually concluding a search term with the Enter key to get the search started, to save a mouse click. This works in SM 2.0.2 but not in the 2.1a1pre nightlies, where the search dialog is just aborted. This happens on both IMAP and Local Folders, but the error console only seems to report an error on an IMAP folder search, and only if it is currently open. [Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20100129 SeaMonkey/2.1a1pre] Steps to reproduce: 1) Right-click on a folder and select "Search Messages"; 2) Enter any search string and finish with the Enter key; 3) Search window unexpectedly closes. Expected behavior: Should start the search. Error Console says (not always): Error: document is null Source File: chrome://messenger/content/mailWindow.js Line: 364
Identical symptoms for Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a1pre) Gecko/20100201 SeaMonkey/2.1a1pre, using a fresh profile.
Same bug on Mozilla/5.0 (X11; U; Linux i686; en; rv:1.9.3a4pre) Gecko/20100402 Mnenhy/0.8.0pre15 SeaMonkey/2.1a1pre.
Created attachment 436682 [details] [diff] [review] fix error and problem The actual problem was caused by bug 515228 (conversion from window to dialog). The document is null error is unrelated but let's fix it while we're here.
(In reply to comment #3) > Created an attachment (id=436682) [details] WFM
Comment on attachment 436682 [details] [diff] [review] fix error and problem >+ if (!document) return; This is just wallpaper, and it's unclear that it's necessary once the underlying bug is fixed. >+ defaultButton="search-button" defaultButton is a btntype, not an id.
Created attachment 436769 [details] [diff] [review] patch v2 (In reply to comment #5) > (From update of attachment 436682 [details] [diff] [review]) > >+ if (!document) return; > This is just wallpaper, and it's unclear that it's necessary once the > underlying bug is fixed. Well, it won't hurt either, right? > >+ defaultButton="search-button" > defaultButton is a btntype, not an id. Hmm, right (dlgtype, actually). I'm a bit confused that it still worked in a way but I agree that my approach was wrong. The new one should be cleaner since it disables the window.close() code path in dialog.xml's _doButtonCommand method that triggered the problem (_fireButtonEvent calls onbuttonaccept).
Created attachment 443215 [details] [diff] [review] patch v3 [Checkin: comment 9]
Comment on attachment 443215 [details] [diff] [review] patch v3 [Checkin: comment 9] http://hg.mozilla.org/comm-central/rev/ed24c9dfc66b
Verified fixed Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100504 SeaMonkey/2.1a1pre nightly build, thanks.