543248 - Improve 'make package-compare' so that it is capable of detecting when new files are added to the build and correctly report failure

Status: RESOLVED WONTFIX

(MailNews Core :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Our current package-compare step is limited by the fact it must manually be checked to see if there are any files we're missing.

We really need to make this automated so that a) we know if we're missing things just by looking at the build status, b) we don't have to keep figuring out which files are good/bad.

Whilst we should be able to do this, there may be some pitfalls worth considering:

1) Some files are generated but not packaged, we can either:
1a) try and get them removed from the dist/bin directory.
1b) add a list of ones to be ignored.

2) --enable-tests will generate extra files into the dist/bin directory :-( We may need to consider these for future work - if we do packaged tests then we'll likely be building with --enable-tests.

This will generate a little extra work to ensure the lists are kept up to date, but that's probably better than missing things as we do now.

Comment 1

[Philippe M. Chiasson (:gozer)]

As a good first incentive, shouldn't a failure of package-compare turn the build orange ?

Comment 2

[Philippe M. Chiasson (:gozer)]

(In reply to comment #0)
>
> 1) Some files are generated but not packaged, we can either:
> 1a) try and get them removed from the dist/bin directory.
> 1b) add a list of ones to be ignored.

We definitely need package-compare to support some sort of an exclusion-list since we have unittest enabled now.

Comment 3

[John Hopkins (:jhopkins)]

Attachment: package-compare differences from Linux comm-central build

Would adding a list of files to be ignored handle the attached package-compare additions?
The 'find' command is limited to just files, so expected directories show up as missing (-) in the diff output.

Now that I've dug into this a bit, it would be useful to chat about this when you have a chance.

Comment 4

[Mark Banner (:standard8)]

We haven't used this tool for ages, I don't think we need this fixing now.