543271 - rules.mk: remove "tier" support code (in SeaMonkey)

Status: VERIFIED INVALID

(SeaMonkey :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

I noticed this while checking
http://hg.mozilla.org/mozilla-central/rev/0cb6d4bc7eae
(no bug): Add echo-tier-dirs target, to display tiers' directories. r=bsmedberg

Callek) told me:
{
>> The only reference to tiers is from mozilla/ and our use of tiers in c-c is all imported from mozilla/ anyway (build.mk)
>
> Then, should we be able to remove the other references to "tier" in rules.mk? (and maybe config.mk??)

Probably
}

Comment 1

[Magnus Melin [:mkmelin]]

Only comm-central refs are in calendar/ and suite/
Moving this to seamonkey

Comment 2

[Philip Chee]

The build system has been revamped several times since this bug was opened. I don't think any of this applies any more.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to Philip Chee from comment #2)
> The build system has been revamped several times since this bug was opened.
> I don't think any of this applies any more.

Not obvious to me: make code seems to be duplicated still and add_tier_dir() calls are in m-c only.
I haven't followed what happened for quite some time, yet I would like a bit of confirmation about the current status.
Thanks.

Comment 4

[Justin Wood (:Callek)]

I'm pretty sure tier's are being removed in the main build system now, I'll defer the proper answer to c#3 to jcranmer

Comment 5

[Joshua Cranmer [:jcranmer]]

Tiers as originally conceived are basically dead. The use of add_tier_dir in moz.build is basically an anachronism at this point AFAICT. The use of tiers in the makefiles is actually supposed to be in reference to export/compile/libs/tools, aside from rules that are probably dead.

For what it's worth, I prefer to keep diffs between comm-central and mozilla-central makefiles minimized as we move to eliminating the c-c build system, so I don't think there's anything valuable here.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to Joshua Cranmer [:jcranmer] from comment #5)
> For what it's worth, I prefer to keep diffs between comm-central and
> mozilla-central makefiles minimized as we move to eliminating the c-c build
> system, so I don't think there's anything valuable here.

Thanks for the details. Agreed.
V.Invalid, as reporter.